Merged
Conversation
4bb1331 to
3871785
Compare
4a8175a to
03f2e6d
Compare
03f2e6d to
1cb4f76
Compare
b37cde2 to
15f0993
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 84.70% 84.99% +0.29%
==========================================
Files 112 113 +1
Lines 8243 8389 +146
Branches 1791 1832 +41
==========================================
+ Hits 6982 7130 +148
+ Misses 1232 1230 -2
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
31e3f45 to
797500a
Compare
1d71b48 to
55ff9ca
Compare
Contributor
Author
|
as we discussed, it will be addressed in another PR. |
55ff9ca to
dfddf95
Compare
aa00b05 to
b0a4ba0
Compare
pedroferreira1
approved these changes
Dec 4, 2025
r4mmer
approved these changes
Dec 5, 2025
integration tests review changes review changes: change fee_per_output to biginit review changes: rename function to getDefaultCustomTokenVersion review changes: remove unecessary casting review changes: validateAddress rename, comments fixes fix: integration tests
60733a2 to
467ae8d
Compare
3 tasks
r4mmer
added a commit
that referenced
this pull request
Dec 11, 2025
…-policy * origin/master: (31 commits) feat: fee token creation (#858) fix: checkAddressMine was crashing when called with an empty array (#977) feat: the nano amount field should accept 0 Merge pull request #975 from HathorNetwork/chore/bump-v2.11.0 feat: add nano execution logs API (#973) Refactor: Fullnode facade to Typescript (#972) Merge pull request #970 from HathorNetwork/chore/bump-v2.10.0 fix: added missing tx proposal delete schema (#969) feat: add missing api calls for graphviz and nano (#967) Merge pull request #965 from HathorNetwork/feat/complete-token-info-object chore: bump package to v2.9.1 (#962) feat: catch and store async promise error (#960) chore: bump wallet lib to v2.9.0 (#958) tests: use core v0.67.0 docker image for the integration tests (#956) tests: update integration tests blueprints for the new core sdk (#954) fix: added a minimal accessData so methods that need storage don't crash (#955) feat: fee header (#951) feat: added read-only start (#950) fix: dont add metadata changed for voided txs (#948) test: Wallet Service infrastructure (#909) ...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hathor now supports a new token versioning system, and with it the
FEEversion. The fee will be charged according to the docs:We accept payments with deposit based tokens in the protocol level. However, in our clients we will not. Accepting only payments with HTR.
Acceptance criteria
This PR should enable preparing a transaction taking into account the fee without affecting the current flow.
Some modifications that will be applied on merge:
versionprop toaddCreatedTokenFromTxmethod.saveTokenmethod in theMemoryStoreto set the default token version.Feeutils, containing the methods to calculate fees depending on the scope.CreateTokenTransactionto accept a token version.generalTokenInfoSchemain the wallet schemas to accept anullable version, since HTR is null or undefined.ITokenData, andIHistoryTxto have thetoken_info_versionfield.FEE_PER_OUTPUTconstant.DEFAULT_NATIVE_TOKEN_CONFIGwith theTokenVersion.NATIVEprop.