Skip to content

Chore/bump to 0.39.0 rc.3 - #879

Merged
raul-oliveira merged 1 commit into
release-candidatefrom
chore/bump-to-0.39.0-rc.3
May 29, 2026
Merged

Chore/bump to 0.39.0 rc.3#879
raul-oliveira merged 1 commit into
release-candidatefrom
chore/bump-to-0.39.0-rc.3

Conversation

@raul-oliveira

@raul-oliveira raul-oliveira commented May 29, 2026

Copy link
Copy Markdown
Contributor

Acceptance Criteria

  • Bump package to version 0.39.0-rc.3

Checklist

  • Make sure you updated the CURRENT_PROJECT_VERSION with the appropriate release-candidate version in ios/HathorMobile.xcodeproj/project.pbxproj
  • Make sure you updated the MARKETING_VERSION with the appropriate version in ios/HathorMobile.xcodeproj/project.pbxproj
  • Make sure you updated the version attribute in package.json
  • Make sure you updated the version attribute in package-lock.json
  • Make sure you incremented the versionCode attribute in android/app/build.gradle
  • Make sure you updated the versionName with the appropriate version, including the release candidate number in android/app/build.gradle

Summary by CodeRabbit

Release Notes v0.39.0-rc.3

  • New Features

    • Transaction building now displays clear progress indicators with improved error messaging during send flow
  • Bug Fixes

    • Token history automatically refreshes when data becomes invalidated
    • Address Mode menu now displays with correct visibility rules
  • Localization

    • Updated translations for Danish, Portuguese (Brazil), and Russian

Review Change Stack

@raul-oliveira
raul-oliveira requested a review from tuliomir May 29, 2026 14:45
@raul-oliveira raul-oliveira self-assigned this May 29, 2026
@raul-oliveira raul-oliveira moved this from Todo to In Progress (Done) in Hathor Network May 29, 2026
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e35adccb-4945-4b39-a9c6-068e9aa6fbb9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Version bumped to 0.39.0-rc.3 across Android, iOS, and Node manifests. SendAmountInput stripped of client-side fee calculation; SendConfirmScreen refactored to phase-based transaction building with error handling. Token import saga now propagates version field. All translation files updated for code structure changes.

Changes

Release v0.39.0-rc.3 with Send Flow Refactoring

Layer / File(s) Summary
Version bump across manifests and package
android/app/build.gradle, ios/HathorMobile.xcodeproj/project.pbxproj, package.json
Version fields updated to 0.39.0-rc.3 in Android versionCode (127) and versionName, iOS Debug/Release MARKETING_VERSION (0.39.0), and Node package.json.
Token version field in import saga
src/sagas/tokenImport.js
Token import saga extracts and propagates version from fetched token details through fetchTokenDetails, fetchUnregisteredTokens, handleNewTokenDetection, and importSelectedTokens, persisting the field via wallet.storage.registerToken and dispatching it with newToken action.
SendAmountInput refactor—remove client-side fees
src/screens/SendAmountInput.js
Removed TokenVersion import, wallet Redux selector, and async useEffect that calculated networkFee and UTXOs. "Next" button now navigates to SendConfirmScreen with only { address, amount, token }, removing fee-based HTR validation.
SendConfirmScreen refactor—phase-based build flow
src/screens/SendConfirmScreen.js
Refactored to pre-build transaction on mount using explicit PHASE state (BUILDING, ERROR, READY). Added mapTxError helper to translate wallet-lib errors to user text. Transaction preparation via prepare-tx with UTXO reservation/release. UI conditionally renders build spinner, error modal with dismiss handler, and ready-state review only at PHASE.READY.
Supporting UI and settings fixes
src/components/AmountTextInput.js, src/screens/CreateTokenConfirm.js, src/screens/MainScreen.js, src/screens/Settings.js
AmountTextInput documentation clarified for parent-width sizing requirements. CreateTokenConfirm applies alignSelf: 'stretch' style to AmountTextInput. MainScreen adds componentDidUpdate to refetch history on TOKEN_DOWNLOAD_STATUS.INVALIDATED and broadens loading UI state. Settings "Address Mode" conditional switched from reownEnabled to singleAddressEnabled.
Localization updates across all locales
locale/texts.pot, locale/da/texts.po, locale/pt-br/texts.po, locale/ru-ru/texts.po
Source references (#: comments) adjusted throughout for SendAmountInput/SendConfirmScreen refactoring; new message keys added for transaction building/error states, insufficient-balance messages, and fee handling; obsolete entries updated; token creation and swap review references re-anchored.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • HathorNetwork/hathor-wallet-mobile#877: Overlaps directly with the SendAmountInput/SendConfirmScreen refactor, tokenImport.js version propagation, and translation updates.
  • HathorNetwork/hathor-wallet-mobile#878: Shares code changes in Settings.js, MainScreen.js, SendConfirmScreen.js, and CreateTokenConfirm.js—particularly send-confirm error mapping and history invalidation handling.
  • HathorNetwork/hathor-wallet-mobile#834: Related through send-flow UI refactoring that removes client-side fee calculation and introduces transaction-building phase UI with fee labels and token version handling.

Suggested reviewers

  • tuliomir
  • pedroferreira1

Poem

🐰 Version hops to 0.39.0-rc.3 with grace,
Send flows dance through phases—build, error, ready pace,
Tokens carry versions through import's winding road,
Locales whisper translations of the refactored code.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Chore/bump to 0.39.0 rc.3' clearly identifies the main change—a version bump to 0.39.0-rc.3, which aligns with the PR's primary objective and the majority of file changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-to-0.39.0-rc.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raul-oliveira
raul-oliveira changed the base branch from master to release-candidate May 29, 2026 14:45
@github-project-automation github-project-automation Bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network May 29, 2026
@tuliomir tuliomir moved this from In Review (WIP) to In Review (Done) in Hathor Network May 29, 2026
@raul-oliveira
raul-oliveira merged commit 059d7c5 into release-candidate May 29, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network May 29, 2026
@raul-oliveira raul-oliveira moved this from Waiting to be deployed to Done in Hathor Network Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants