Skip to content

feat: passkey wallet — onboarding UI & PIN-less integration #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedroferreira1 wants to merge 3 commits into
base: feat/passkey-core
Choose a base branch
from
Open

feat: passkey wallet — onboarding UI & PIN-less integration #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6625648
feat(passkey): onboarding UI + PIN-less wallet integration
pedroferreira1 Jul 27, 2026
624b6a3
refactor(passkey): extract a shared authorizeTransaction helper
pedroferreira1 Jul 27, 2026
0e63b48
fix(passkey): address PR #897 review — saga retries, error handling, …
pedroferreira1 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions __tests__/passkey/passkeySigner.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ import {
consumePasskeySigningCancelled,
PasskeyCancelledError,
PasskeyXpubMismatchError,
PasskeyMetadataMissingError,
PasskeyBusyError,
} from '../../src/passkey/passkeySigner';
/* eslint-enable import/first, import/order */
Expand Down Expand Up @@ -121,13 +122,16 @@ describe('makePasskeyTxSigner', () => {
expect(err.storedLabel).toBe(STORED_LABEL);
});

test('throws PasskeyXpubMismatchError when no xpub is stored at all', async () => {
test('throws PasskeyMetadataMissingError (not mismatch) when no xpub is stored at all', async () => {
// A missing stored xpub is corrupted/incomplete metadata, NOT a wrong passkey — it must be
// diagnosed distinctly (reset, not "use the other passkey").
STORE.getWalletMeta.mockReturnValue(makeMeta({ xpub: undefined }));

const signer = makePasskeyTxSigner();
const err = await signer(fakeTx, fakeStorage).catch((e) => e);

expect(err).toBeInstanceOf(PasskeyXpubMismatchError);
expect(err).toBeInstanceOf(PasskeyMetadataMissingError);
expect(err).not.toBeInstanceOf(PasskeyXpubMismatchError);
expect(transactionUtils.signTxInputs).not.toHaveBeenCalled();
});

Expand Down
Loading