feat: guard fee-based token sends on hardware wallets - #885
Merged
Conversation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
raul-oliveira
force-pushed
the
raul-oliveira/feat/ledger-fee-token-guard
branch
from
July 10, 2026 18:35
c292d0c to
843d11e
Compare
pedroferreira1
approved these changes
Jul 15, 2026
tuliomir
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Context
The Hathor Ledger app cannot deserialize a transaction that carries a fee header:
getDataToSign()appends theFeeHeaderbytes after the outputs, and the device's parser rejects the trailing bytes (SW_INVALID_TX). Until the Ledger app learns to parse headers, we block the send early with a clear message, mirroring the existingisLedgerCustomTokenAllowed()guard and reusing theALERT_NOT_SUPPORTEDmodal.The token is detected as fee-based via its
version(TokenVersion.FEE), read from the Reduxtokenslist (kept fresh byuseTokensDetails).Screenshots
Security Checklist
src/screens/SendTokens.js.Summary by CodeRabbit