Skip to content

[v0.35.0] Sync master with release - #890

Closed
raul-oliveira wants to merge 12 commits into
masterfrom
release
Closed

[v0.35.0] Sync master with release#890
raul-oliveira wants to merge 12 commits into
masterfrom
release

Conversation

@raul-oliveira

Copy link
Copy Markdown
Contributor

Acceptance Criteria

  • Sync the master branch with the changes from the latest release v0.35.0

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

raul-oliveira and others added 12 commits May 12, 2026 13:19
Release candidate v0.35.0-rc.1
… Home) (#878)

The fee-token send refactor replaced the ModalPin/ModalSendTx flow with
ModalTransactionOverview and ModalSendSuccess, dropping two behaviors:

- The PIN field was no longer auto-focused. The overview modal relied on
  the input's `autoFocus`, which fires while the modal is still
  display:none, so the browser ignores it. Focus the field on Bootstrap's
  `shown.bs.modal` event instead (the old ModalPin approach), which also
  restores focus across every flow that uses the shared overview modal.

- The success modal's "Close" (and top-right "x") only reset the form and
  stayed on the Send screen. They now navigate to the wallet home
  (/wallet/), restoring the pre-refactor behavior; the now-dead resetForm
  helper is removed.
… PIN) (#881)

Fixes a batch of UX regressions introduced in the 0.35.0 release candidates:

- Address mode kept across passphrase changes: adding/removing a passphrase no
  longer forces the wallet into multi-address mode. startWallet re-syncs the
  feature toggles from the live Unleash singleton before reading the
  single-address flag, so the clean_data reset in the passphrase flow no longer
  makes the flag read a stale default.

- Import Tokens banner no longer advertises phantom tokens: unregistering a
  token with no history and zero balance now clears it from allTokens and
  tokensBalance, so fetchUnknownTokens stops reporting a token the import modal
  cannot resolve.

- Easy Import Tokens "Open in Explorer" opens the system default browser via
  helpers.openExternalURL instead of a new Electron window.

- Send Tokens confirmation validates the PIN with wallet.checkPin before
  sending, showing "Invalid PIN" on the review screen instead of a generic
  "Transaction failed" after a failed send attempt.
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@raul-oliveira, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2a759dd9-6869-44ae-b53a-ec729cbdaecd

📥 Commits

Reviewing files that changed from the base of the PR and between a392847 and fbc0883.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (8)
  • lavamoat/webpack/policy-override.json
  • package.json
  • src/components/ModalTokenImport.js
  • src/components/ModalTransactionOverview.js
  • src/reducers/index.js
  • src/sagas/featureToggle.js
  • src/sagas/wallet.js
  • src/screens/SendTokens.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@raul-oliveira

Copy link
Copy Markdown
Contributor Author

Superseded by #891. This branch (releasemaster) has a package.json / package-lock.json conflict because master advanced past the release cut (#873 bumped @hathor/hathor-rpc-handler 4.4.0 → 5.0.0). #891 resolves it on a dedicated branch (branched off master, merged release in), keeping master's rpc-handler 5.0.0 and stamping version 0.35.0, without touching release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants