fix(amount): wrap read-only amount labels instead of overflowing - #897
Open
raul-oliveira wants to merge 1 commit into
Open
Conversation
The deposit, fee, available-balance and summary labels on Create Token, Create Fee Token, Create NFT and Send Tokens forced long amounts onto a single line, overflowing their cards. Add a shared `.amount-label` class (overflow-wrap: anywhere) to those read-only labels so they wrap inside the container. The editable amount input is untouched -- it already accepts unlimited decimals with the caret pinned to the end. The Mint deposit label is rendered by the shared TokenAction component, so it gains an opt-in `depositClassName` prop passed only from TokenMint, leaving Delegate and Destroy unaffected.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
masterSixth and final PR. Stacked on #896 — base branch is
raul-oliveira/feat/amount-format-tx-overview, notmaster. Review #896 first.What changed
Layout only. A shared
.amount-labelclass (overflow-wrap: anywhere; white-space: normal; max-width: 100%) is added to the read-only amount labels:TokenActioncomponent (also used by Delegate / Destroy), soTokenActiongains an opt-indepositClassNameprop passed only fromTokenMint; Delegate and Destroy renderclassName={undefined}(no attribute) and are unaffected.InputNumber(the editable input) is deliberately untouched — it already accepts unlimited decimals via BigInt accumulation with the caret pinned to the end. Token Melt has no persistent read-only deposit label (only a toast and an error line that already wrap), so it needed no change.Testing
Suite unchanged from #896: the same 7 pre-existing suites fail on the Jest/axios ESM issue (see #892),
33 passed. No new strings.Manual QA needed
master.Security Checklist