fix: read x402 payment response header - #15
Open
peterxing wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PAYMENT-RESPONSEheader on successful paid responses in the browser dApppaymentobject for compatibilityWhy
Issue #3 calls out that the spec-compliant settlement channel is the
PAYMENT-RESPONSEHTTP header. The resource server on the current POC branch already emits it; this patch makes both example clients consume it instead of relying only on the convenience JSON body.Verification
git diff --checknode --check client.jsPAYMENT_RESPONSE_DECODE_OKnpm run lint --prefix dapp -- --file components/X402Fetch.tsxnpm run build --prefix dappNote: direct
tsc --noEmit -p dapp/tsconfig.jsonis currently blocked by pre-existing test/mock type errors outside this patch (dapp/__mocks__/hathorCoreAPI.ts,dapp/__tests__/unit/hathorRPC.test.ts, etc.). The Next production build passed.Refs #3