adds new plugin #266

DavidReinberger · 2022-02-01T22:39:44Z

No description provided.

HaveAGitGat · 2022-02-07T05:46:42Z

Fixed some errors so should be working fine now.

DavidReinberger · 2022-02-08T21:51:54Z

Hey @HaveAGitGat Sorry for Force pushing after your updates but I've made a lot of changes over the last few dates and did not pushed them... Please have a look at it now.

DavidReinberger · 2022-02-18T16:52:54Z

@HaveAGitGat Hello, I've finally finalized the plugin and added a new one. Could you take a look at it now please? :) Thanks

HaveAGitGat · 2022-03-07T08:41:19Z

@DavidReinberger sorry missed this. Seems when running the checkPlugins script there are a couple of things missing.

HaveAGitGat · 2022-03-18T12:28:29Z

Thanks, will have a look through this tomorrow.

HaveAGitGat · 2022-03-19T16:20:18Z

Added some fixes from the checkPlugins test.

I've tried Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER and tbh I'm not too sure of the purpose of the plugin as there's a lot going on.

I've run it on a bunch of h264, hevc and vp9 files (default settings) and it only seems to be changing the audio. Even when setting forceHevc it does not seem to do any video transcoding so seems there is a bug in it.

supersnellehenk · 2022-02-03T11:19:36Z

Community/Tdarr_Plugin_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+  const isAlreadyProcessed = file.ffProbeData.tags[CUSTOM_TAG] === 'YES';
+
+  if (isAlreadyProcessed) {


Can be merged together

supersnellehenk · 2022-02-03T11:19:47Z

Community/Tdarr_Plugin_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+  const isAlreadyProcessed = file.ffProbeData.tags[CUSTOM_TAG] === 'YES';
+
+  if (isAlreadyProcessed) {
+    response.processFile = false;


Unnecessary processFile

supersnellehenk · 2022-02-03T11:19:56Z

Community/Tdarr_Plugin_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+  }
+
+  if (file.fileMedium !== 'video') {
+    response.processFile = false;


Unnecessary processFile

supersnellehenk · 2022-03-20T00:12:51Z

Community/Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+  // eslint-disable-next-line max-len
+  if (!supportedResolutions.includes(resolution)) throw new Error(`Unsupported Resolution: ${resolution}, supported are only ${supportedResolutions.join(', ')}`);


You can just encase it in brackets, should get rid of the max length issue.

supersnellehenk · 2022-03-20T00:14:03Z

Community/Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+  // eslint-disable-next-line max-len
+  Description: '[Contains built-in filter] Single-pass transcoder to optimize a media file to be used with Plex/Emby etc.',
+  Version: '1.0',
+  Tags: 'pre-processing,ffmpeg,hevc,x264,vaapi,nvenc,configurable,audi,video,subtitles',


Unsupported tags. https://github.com/HaveAGitGat/Tdarr_Plugins/blob/master/examples/Tdarr_Plugin_pre1_Pre_Proc_Example.js#L22

supersnellehenk · 2022-03-20T01:53:04Z

Community/Tdarr_Plugin_dt0y_DaveThe0nly_Subtitle_Extractor.js

+const dispositionMap = {
+  forced: 'forced',
+  hearing_impaired: 'sdh',
+};


Only used once, can be hardcoded on line 109 and 110.

supersnellehenk · 2022-03-20T01:54:12Z

Community/Tdarr_Plugin_dt0y_DaveThe0nly_Subtitle_Extractor.js

+  id: 'Tdarr_Plugin_dt0y_DaveThe0nly_Subtitle_Extractor',
+  Stage: 'Pre-processing',
+  Name: 'Extract Subtitles from video',
+  Type: 'Video',


I'd say this is a Subtitle plugin and not Video

supersnellehenk · 2022-03-20T01:57:30Z

Community/Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+  // This takes the first stream as the best stream to derive new ones from
+  const [
+    {
+      index: bestStreamOriginalIndex, channels: bestStreamChannels, codec: bestAudioStreamCodec, ...bestAudioStream


Objects should have all their properties on new lines

supersnellehenk · 2022-03-20T02:02:17Z

Community/Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+  if (file.fileMedium !== 'video') {
+    response.processFile = false;
+    response.infoLog += 'File is not a video. Exiting \n';
+    return response;
+  }
+
+  if (!file.ffProbeData.streams.length) {
+    response.processFile = false;
+    response.infoLog += 'No streams to process!! \n';
+    return response;
+  }


In these cases the file should probably just error out instead of silently fail like it does now.

supersnellehenk · 2022-03-20T02:03:47Z

Community/Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

+      defaultValue: '.mp4',
+      inputUI: {
+        type: 'dropdown',
+        options: ['.mp4', '.mkv', 'keep'],


Please keep all options on separate lines like you did for the true/false dropdown :D

HaveAGitGat · 2022-05-22T16:52:25Z

FYI will merge this when I've caught up on the new plugins tests and had time to do some for this one, you can see the tests for other plugins here: https://github.com/HaveAGitGat/Tdarr_Plugins/tree/master/tests/Community

Run using npm run test

HaveAGitGat · 2022-05-23T18:24:05Z

Added some more tests and caught a few things on Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER

So first thing like you say is the macos hardware acceleration.

Next thing is the remove commentary track isn't working:

Tdarr_Plugins/tests/Community/Tdarr_Plugin_dt0y_DaveThe0nly_HWACCEL_SINGLE_TRANSCODER.js

Line 241 in e58e8a0

keepCommentaryAudioTracks: false,

For some reason coming back as processFile: false when a mock commentary track is added.

Maybe you can take a look?

Then will need to add some tests for the other inputs too

adds new plugin

3b17c08

DavidReinberger force-pushed the feat/davetheonly-coder branch from d005da7 to 3b17c08 Compare February 1, 2022 22:40

HaveAGitGat changed the base branch from master to log_fixes February 8, 2022 02:31

HaveAGitGat changed the base branch from log_fixes to master February 8, 2022 02:31

HaveAGitGat previously approved these changes Feb 8, 2022

View reviewed changes

HaveAGitGat requested review from supersnellehenk and vodkapmp February 8, 2022 02:35

adds more options and finalizes transcoder

54f3d2d

DavidReinberger dismissed HaveAGitGat’s stale review via 54f3d2d February 8, 2022 21:51

DavidReinberger force-pushed the feat/davetheonly-coder branch from 0dc94f5 to 54f3d2d Compare February 8, 2022 21:51

DavidReinberger requested a review from HaveAGitGat February 8, 2022 21:51

DavidReinberger marked this pull request as draft February 14, 2022 13:07

finalizes plugin and adds extractor

11ba68f

DavidReinberger marked this pull request as ready for review February 18, 2022 16:52

DavidReinberger added 2 commits February 19, 2022 21:15

adds more logging and fixes a condition

8055487

restructure some code, fix some bugs and add remove from plex ignore

8b7dfea

DavidReinberger added 5 commits March 16, 2022 12:18

other fixes

1be10bc

other fixes

221e50c

other fixes

6e36a11

other fixes

af004c1

other fixes

b32ebd1

HaveAGitGat added 4 commits March 19, 2022 15:59

Fix checkPlugins errors

24120ff

Add code id to plugin

fa3ff73

Fix lint errors

b045ead

Fix type

b6a534f

supersnellehenk requested changes Mar 20, 2022

View reviewed changes

handle commentary audio properly

2b23af8

DavidReinberger and others added 21 commits May 23, 2022 08:37

adds new plugin

34b91c6

adds more options and finalizes transcoder

d2f07a4

finalizes plugin and adds extractor

6e1c1fb

adds more logging and fixes a condition

bee3d9a

restructure some code, fix some bugs and add remove from plex ignore

de7be2c

other fixes

a344a42

other fixes

242af2e

other fixes

fba9b99

other fixes

55c1046

other fixes

c2f1dda

Fix checkPlugins errors

9000b65

Add code id to plugin

7b675fa

Fix lint errors

8dad01a

Fix type

899a6a9

handle commentary audio properly

6897c47

Add Tdarr_Plugin_dt0y_DaveThe0nly_Subtitle_Extractor tests

92da005

Rebase

2fb2759

Fix checkPlugins

0615791

Remove skip test

fd3b310

Fix error

63bd2ca

Add some more tests

e58e8a0

Merge branch 'master' into pr/266

bb86095

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds new plugin #266

adds new plugin #266

DavidReinberger commented Feb 1, 2022

HaveAGitGat commented Feb 7, 2022

DavidReinberger commented Feb 8, 2022

DavidReinberger commented Feb 18, 2022

HaveAGitGat commented Mar 7, 2022

HaveAGitGat commented Mar 18, 2022

HaveAGitGat commented Mar 19, 2022

supersnellehenk Feb 3, 2022

supersnellehenk Feb 3, 2022

supersnellehenk Feb 3, 2022

supersnellehenk Mar 20, 2022

supersnellehenk Mar 20, 2022

supersnellehenk Mar 20, 2022

supersnellehenk Mar 20, 2022

supersnellehenk Mar 20, 2022

supersnellehenk Mar 20, 2022

supersnellehenk Mar 20, 2022

HaveAGitGat commented May 22, 2022

HaveAGitGat commented May 23, 2022

		const isAlreadyProcessed = file.ffProbeData.tags[CUSTOM_TAG] === 'YES';

		if (isAlreadyProcessed) {

		// eslint-disable-next-line max-len
		if (!supportedResolutions.includes(resolution)) throw new Error(`Unsupported Resolution: ${resolution}, supported are only ${supportedResolutions.join(', ')}`);

adds new plugin #266

Are you sure you want to change the base?

adds new plugin #266

Conversation

DavidReinberger commented Feb 1, 2022

HaveAGitGat commented Feb 7, 2022

DavidReinberger commented Feb 8, 2022

DavidReinberger commented Feb 18, 2022

HaveAGitGat commented Mar 7, 2022

HaveAGitGat commented Mar 18, 2022

HaveAGitGat commented Mar 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HaveAGitGat commented May 22, 2022

HaveAGitGat commented May 23, 2022