Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js #339

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Create Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js #339

wants to merge 13 commits into from

Conversation

cjmanca
Copy link

@cjmanca cjmanca commented Oct 5, 2022

Video transcode plugin (FFMPEG NVENC h265)

  • Post transcode size filter, but instead of cancelling stack, will rollback to original video to allow other audio/subtitle plugins to execute. Recommended to place this as the first plugin, so the size filter will only check the video stream size difference.
  • Will detect HDR and tonemap to SDR.
  • Uses different FFMPEG NVENC transcoding settings for 480p,576p,720p,1080p and 4KUHD.
  • 10 bit output.
  • The output container is mkv. Converts or strips streams which mkv doesn't support.
  • bFrame support.

supersnellehenk
supersnellehenk requested changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@supersnellehenk supersnellehenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files need tests written and need to be linted by EsLint.

supersnellehenk
supersnellehenk requested changes Oct 19, 2022
View reviewed changes
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
Community/Tdarr_Plugin_advo_FFMPEG_NVENC_Tiered_MKV_with_rollback.js Outdated Show resolved Hide resolved
cjmanca and others added 4 commits November 14, 2022 18:40
@cjmanca
Select lowest bitrate
818d6b4 
The mediainfo bitrate isn't always accurate. Sometimes it shows the original remux size rather than the current video stream size, which could cause it to choose incorrectly. Now selects the smallest of the bitrates (out of those considered valid).
@cjmanca
Fix for undefined initial bitrate
610515e
@cjmanca
Fixes/additions
6f2051d 
Added custom extra ffmpeg command input
Added av1BitrateCutoff and otherCodecBitrateCutoff
Fix for webvtt subtitles not being detected by ffmpeg
@HaveAGitGat
Merge branch 'master' into pr/339
5071889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersnellehenk supersnellehenk Awaiting requested review from supersnellehenk

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjmanca @supersnellehenk @HaveAGitGat