error if we inline a static local

closes #11725
HaxeFoundation · Jul 18, 2024 · 2d44cce · 2d44cce
1 parent 3b5b3cc
commit 2d44cce
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/src/optimization/inline.ml b/src/optimization/inline.ml
@@ -700,6 +700,7 @@ let rec type_inline ctx cf f ethis params tret config p ?(self_calling_closure=f
 				typing_error "Could not inline `this` outside of an instance context" po
 			)
 		| TVar (v,eo) ->
+			if has_var_flag v VStatic then raise_typing_error "Inline functions cannot have static locals" v.v_pos;
 			{ e with eexpr = TVar ((state#declare v).i_subst,opt (map false false) eo)}
 		| TReturn eo when not state#in_local_fun ->
 			if not term then begin

diff --git a/tests/misc/projects/Issue11725/Main.hx b/tests/misc/projects/Issue11725/Main.hx
@@ -0,0 +1,6 @@
+function main() foo();
+
+inline function foo() {
+	static var count = 5;
+	trace(--count);
+}
diff --git a/tests/misc/projects/Issue11725/compile-fail.hxml b/tests/misc/projects/Issue11725/compile-fail.hxml
@@ -0,0 +1,2 @@
+--main Main
+--interp
diff --git a/tests/misc/projects/Issue11725/compile-fail.hxml.stderr b/tests/misc/projects/Issue11725/compile-fail.hxml.stderr
@@ -0,0 +1 @@
+Main.hx:4: characters 13-18 : Inline functions cannot have static locals