[CI] Run display tests with both xml and json rpc api #11506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also run again a couple tests after caching type
(same as xml display api)
|
I think that test is simply invalid for the new protocol because it reports everything and tells the IDE how to qualify identifiers in case of conflict. |
|
Hmm, fair enough. Will update the test then. |
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
…#11506) * [tests] prepare for json rpc vs xml display tests * [tests] add display test for static field completion Also run again a couple tests after caching type * [tests] display test with both xml and json rpc api * [ci] run both xml and jsonrpc display tests * [display] send completion error when no results (same as xml display api) * [tests] don't rely on result.result == null on completion error * [tests] only run Toplevel.testDuplicates for xml display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... when available. Still need to migrate module-symbols to json rpc.
I made a bit of a mess while making sure json rpc api was giving the results expected by tests written for xml api. Should be possible to clean it up quite a bit when actually removing xml api.
One test is failing with json rpc, and it seems like this is because #6341 has been handled on xml api but not on json rpc? cc @Simn