4.3.4

[kLabz]

Warning

This is to be merged to 4.3_bugfix (do not squash!)

• CI fixes
• Deprecation warnings
• Warn for --java ... -D jvm to be replaced with --jvm ...
• Backport bugfixes - Pull requests for 4.3 Hotfix (part 4) #11394
• Update changelog

Backported bugfixes from 4.3 Hotfix Candidates

• Allow @:using with Class and Enum #11553
• HxOverrides undefined or missing members unless --dce set to no #11427
• [display] expose list of metadata/defines #11399
• inline constructor of abstracts #11526
• Safe navigation is invalid for assigning variables #11379 (not worth it)
• No hover/definition for overload call #11285
• No documentation / goto data with safe nav access #11205
• [hl] Fix do-while loop in genhl+hlopt #11461 (no semantic difference, not worth it)
• [hl] hlopt rework try-catch control flow #11581
• Enum abstract not checked #11577 (old regression)

Update -D haxe-next behavior

• Not sure what to do about Rework module resolution #11168 (let's not even try)

Start applying some haxe 5 behavior:

• [macro] Build order vs inheritance #11582
• Dont infer string on concat #11318
• [typer] don't type trailing optional bind arguments so weirdly #11533

[kLabz]

Regarding the bind change:

function f(notOpt:Int, ?opt:String) {}
function g(notOpt:Int, alsoNotOpt:Bool, ?opt:String) {}

function main() {
	var fBind = f.bind(1);
	var gBind = g.bind(1);
	$type(fBind);
	$type(gBind);

	var fBind = f.bind(1, _);
	$type(fBind);

	var f1 = f.bind(1, null);
	$type(f1);

	var g1 = g.bind(1, _, null);
	$type(g1);
}

Gives:

# 5.0.0 nightlies
src/Main.hx:7: characters 8-13 : Warning : (?opt : Null<String>) -> Void
src/Main.hx:8: characters 8-13 : Warning : (alsoNotOpt : Bool, ?opt : Null<String>) -> Void
src/Main.hx:11: characters 8-13 : Warning : (?opt : Null<String>) -> Void
src/Main.hx:14: characters 8-10 : Warning : () -> Void
src/Main.hx:17: characters 8-10 : Warning : (alsoNotOpt : Bool) -> Void

# 4.3.3
src/Main.hx:7: characters 8-13 : Warning : () -> Void
src/Main.hx:8: characters 8-13 : Warning : (alsoNotOpt : Bool) -> Void
src/Main.hx:11: characters 8-13 : Warning : (?opt : Null<String>) -> Void
src/Main.hx:14: characters 8-10 : Warning : () -> Void
src/Main.hx:17: characters 8-10 : Warning : (alsoNotOpt : Bool) -> Void

# 4.3.4 nightlies
src/Main.hx:7: characters 8-13 : Warning : () -> Void
src/Main.hx:8: characters 8-13 : Warning : (alsoNotOpt : Bool) -> Void
src/Main.hx:11: characters 8-13 : Warning : (?opt : Null<String>) -> Void
src/Main.hx:14: characters 8-10 : Warning : () -> Void
src/Main.hx:17: characters 8-10 : Warning : (alsoNotOpt : Bool) -> Void

# 4.3.4 nightlies with -D haxe-next
src/Main.hx:7: characters 8-13 : Warning : (?opt : Null<String>) -> Void
src/Main.hx:8: characters 8-13 : Warning : (alsoNotOpt : Bool, ?opt : Null<String>) -> Void
src/Main.hx:11: characters 8-13 : Warning : (?opt : Null<String>) -> Void
src/Main.hx:14: characters 8-10 : Warning : () -> Void
src/Main.hx:17: characters 8-10 : Warning : (alsoNotOpt : Bool) -> Void

[kLabz]

(disregard the branch name, this branch is pretty much about all changes between 4.3.3 and 4.3.4 now)

I've added some changes that I thought we might want to add in addition to the ones tracked in #11394:

• Allow @:using with Class and Enum #11553
• HxOverrides undefined or missing members unless --dce set to no #11427
• [display] expose list of metadata/defines #11399
• inline constructor of abstracts #11526

I can obviously remove some/all from here if that's an issue.

There are also a few more changes that I didn't add (yet), for which there are conflicts / I have some doubts / there is still some work to do:

• [messageReporting] Add config to use absolute positions #11439 - conflicts as I rewrote message reporting on nightlies
• Safe navigation is invalid for assigning variables #11379 - conflicts; do we want this?
• No documentation / goto data with safe nav access #11205 - conflicts; do we want this?
• [hl] Fix do-while loop in genhl+hlopt #11461 - I think we'd want this?
• [hl] hlopt rework try-catch control flow #11581 - Not merged yet, guess we'd want this too?
• Enum abstract not checked #11577 - I suppose it'd be nice too, but is it done?

As for -D haxe-next, I'm not sure what can be done about Rework module resolution #11168 ; any idea?

[RblSb]

Would like to have 03aa20e, change seems pretty small?

[kLabz]

Already cited above