-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix licensing #11782
Fix licensing #11782
Conversation
Split licenses to directory-based licensing to precise what files are under GPL or MIT.
I don't know if we want to assert that all other files are part of the Haxe compiler. I don't think you typically declare a tests directory as part of a compiler, and the libs directory is another situation entirely. But I'm fine with clarifying that the Haxe standard library refers to std in particular. |
It's hard for me to tell later if the files included in the tests are GPL or not. Same for all files in the top directory |
And there can be exception for particular directories like |
@Simn like these files: |
@Simn what do you think about that? |
To be honest I don't understand what you're saying. You mention that there can be exceptions, but the change in this PR doesn't seem to make exceptions and says "all other files". |
I haven't done this yet, I will add it in a few minutes. I just want to make sure it is okay. |
@Simn What about now? |
I like that "If a file does not have a license header" clause, that seems uncomplicated enough. So I think this is good now, but let me leave this PR open for a few days in case someone who knows about all this stuff happens to pass by! |
Okay, thanks |
So I think this is good now, but let me leave this PR open for a few days in case someone who knows about all this stuff happens to pass by! @Simn any updates here? |
Split licenses to directory-based licensing to precise what files are under GPL or MIT.