-
Notifications
You must be signed in to change notification settings - Fork 213
Fixed some warnings on MinGW target when compiling Socket.cpp.
#1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
By looking at this issue #574 maybe something might break without |
|
@hughsando Can i get a review on this pr? |
|
Also should be investigated whether it is still necessary to set |
|
The unnecessary Here is a similar example from microsoft documentation of using
Mingw-w64 now defines So these changes seem to be correct. |
tobil4sk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained a both, these solutions to these warnings make sense and would be useful for cleaning up the compilation output with mingw.
This PR fixes the following build warnings:
Redefinition of
_WIN32_WINNT: The macro_WIN32_WINNTwas being redefined inSocket.cpp. A conditional check has been added to prevent this.Ignored
dllimportattribute: Warnings related to thedllimportattribute forinet_pton_funcandinet_ntop_funcwere addressed by removing the unnecessaryWINSOCK_API_LINKAGE.