Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic operations. #985

Merged
merged 12 commits into from
Nov 21, 2022
Merged

Conversation

Apprentice-Alchemist
Copy link
Contributor

@Simn
Copy link
Member

Simn commented Mar 26, 2022

@hughsando Could you take a quick look if this is the right approach for hxcpp?

@hughsando
Copy link
Member

Do these differ from the versions in include/hx/Thread.h ?

@Apprentice-Alchemist
Copy link
Contributor Author

Oh right, forgot those were a thing.
Let's see, there's more operations, and these only uses intrinsics (those macOS OSAtomic* functions are deprecated).

If you prefer I can merge the two sets of atomic operations.

@Simn
Copy link
Member

Simn commented Apr 4, 2022

Yes, I think that would be better.

@Apprentice-Alchemist
Copy link
Contributor Author

Apprentice-Alchemist commented Apr 10, 2022

I'm not sure why the CI hung, that test works fine on my machine....
CI works fine now.

include/hx/StdLibs.h Outdated Show resolved Hide resolved
@Simn Simn merged commit aebf08f into HaxeFoundation:master Nov 21, 2022
@thomasuster
Copy link
Contributor

Is this what broke android? haxenme/nme#720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants