Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module resolution for Haxe 5 #228

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix module resolution for Haxe 5 #228

merged 1 commit into from
Sep 28, 2023

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Sep 28, 2023 •
edited
Loading

@kLabz
Copy link
Contributor Author

kLabz commented Sep 28, 2023

CI failure: need to update format lib to latest git

@Simn
Copy link

Simn commented Sep 28, 2023

It's good to document why these changes are necessary: Here the module in question has import haxe.macro.Type, so Type would resolve to that.

@Simn Simn merged commit 76139e8 into HeapsIO:master Sep 28, 2023
1 check failed
@kLabz kLabz mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kLabz @Simn