Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The big patch #1 (background imgs, settings page, bug fixes, etc...) #74

Open
wants to merge 159 commits into
base: master
Choose a base branch
from

Conversation

mkg20001
Copy link

@mkg20001 mkg20001 commented Apr 1, 2017

Adds the ability to set a color and/or an image as background and a lot more features
Also there are other small fixes

@mkg20001
Copy link
Author

mkg20001 commented Apr 1, 2017

There is a weird bug.
After setting the background for the first time it's added to the non-optional files which causes signing to fail.
But after posting an image both files are added as optional files.
That's weird

@danimesq
Copy link
Contributor

danimesq commented Apr 1, 2017

Please show us a screenshot.

@mkg20001
Copy link
Author

mkg20001 commented Apr 1, 2017

1491066855
Here it is

@danimesq
Copy link
Contributor

danimesq commented Apr 1, 2017

Very welcome update!
Please say me what do you think about this update:
#66

@mkg20001
Copy link
Author

mkg20001 commented Apr 1, 2017

Nice

@danimesq
Copy link
Contributor

danimesq commented Apr 1, 2017

Can you try to add the profile covers feature?

@mkg20001
Copy link
Author

mkg20001 commented Apr 1, 2017

What do you mean exactly?

@danimesq
Copy link
Contributor

danimesq commented Apr 1, 2017

@mkg20001
Copy link
Author

mkg20001 commented Apr 1, 2017

Ok, but we already have a background image
We could add it but it would require a layout change

@danimesq
Copy link
Contributor

danimesq commented Apr 1, 2017

The background image the others can see in the profile, or it is only for the user?
My proposal about covers is the made it public in the profiles.

@mkg20001
Copy link
Author

mkg20001 commented Apr 1, 2017

It is public

@danimesq
Copy link
Contributor

danimesq commented Apr 1, 2017

Some updates working in background (but no messages about it), with patience now its working.

@mkg20001 mkg20001 changed the title Add background images and colors Add background images and other stuff Apr 2, 2017
@mkg20001
Copy link
Author

mkg20001 commented Apr 2, 2017

  • Make other user's background optional
  • Add ability to disable background features
  • Add ability to disable background on feed
  • Add white background to sidebar
  • Improve default background and color
  • Make the background image an optional file
  • Add permalink to date
  • Fix permalinks for comments

@danimesq
Copy link
Contributor

@shortcutme, can you review it?

@mkg20001
Copy link
Author

@Plasmmer I added the 2 column view, but currently it's very buggy.

@danimesq
Copy link
Contributor

danimesq commented Apr 16, 2017

I added the 2 column view, but currently it's very buggy.

Reference: ZeroNerds#97.

@mkg20001
Copy link
Author

mkg20001 commented May 6, 2017

@HelloZeroNet Could you review please?

@HelloZeroNet
Copy link
Owner

HelloZeroNet commented May 7, 2017

Thanks it has lots of great modifications! I prefer the current, simplier design, so maybe it would be better to allow people to choose between the two merger sites.
Right now I working on a site that is showcases user created content on ZeroNet instead of current welcome page, so it will make it easer to find new sites.
What do you think?

@mkg20001
Copy link
Author

mkg20001 commented May 7, 2017

Great idea!
But there should be a way for the community and not just a single person to determine what should be showcased.

@danimesq
Copy link
Contributor

danimesq commented May 7, 2017

It can be a page with all items and upvote buttons,, and in top the most upvoted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants