feat(eval): cover unresolved-symbol fallback in pre-edit gate - #257
Merged
Conversation
Add a third golden query that requests edit context for a symbol that cannot be resolved. The dataset asserts the tool routes to the conceptual search pack (expectedRoute=search) and surfaces the formatResolutionRisk implementation chunk in src/tools/edit-context.ts. Update the documented mock-embedding baseline for the 3-query dataset: response tokens average 358.5 -> 314.3, selected-file ratio 0.7857 -> 0.8571, hit/mrr per 1k response tokens 2.789 -> 3.181, p95 latency 687ms -> 672ms. All budget thresholds in pre-edit.json still pass (Hit@5 1.0, MRR@10 1.0, graph-neighbor recall 1.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #256: completes the acceptance-gate coverage required by
docs/pre-edit-context-design.mdfor fallback behavior on an ambiguous or unresolved symbol.Changes
edit-context-unresolved-fallbacktobenchmarks/golden/pre-edit-context.json. It requests edit context for a symbol that cannot be resolved and asserts:expectedRoute: "search"(routing to the conceptual fallback pack, not a false definition hit)expectedOutcome: "results"formatResolutionRiskinsrc/tools/edit-context.tsVerification
--ci --budget benchmarks/budgets/pre-edit.json): Hit@5 100%, MRR@10 1.0, graph-neighbor recall 1.0, violations none, CI gate PASS.npm run typecheck,npm run lint, and eval unit tests (eval-schema, eval-budget, eval-metrics: 43 tests) pass.