Open
Conversation
Owner
|
This one is quite tricky Your fix almost works for command, but doesn't really work for other dialogs(try ssh download or edit pinned link) And it doesn't prevent style leaks. For example, most of CS1002 files have styles that break dialogs So, I would keep shadow dom while fixing, if possible |
Contributor
Author
|
I think cause of the shadow dom css can not work, so i recommend to replace the shadow dom. |
Owner
|
I don't really like how isolating shadow dom is, but its impossible to perfectly isolate styles using other ways for example, when on CS1002 and viewing SSH download dialog without it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.