Skip to content

chore: fix scroll bug #163#164

Open
huccct wants to merge 1 commit intoHerobread:mainfrom
huccct:main
Open

chore: fix scroll bug #163#164
huccct wants to merge 1 commit intoHerobread:mainfrom
huccct:main

Conversation

@huccct
Copy link
Copy Markdown
Contributor

@huccct huccct commented Mar 19, 2025

No description provided.

@Herobread Herobread linked an issue Mar 19, 2025 that may be closed by this pull request
@Herobread
Copy link
Copy Markdown
Owner

This one is quite tricky

Your fix almost works for command, but doesn't really work for other dialogs(try ssh download or edit pinned link)

And it doesn't prevent style leaks. For example, most of CS1002 files have styles that break dialogs

So, I would keep shadow dom while fixing, if possible

@huccct

@huccct
Copy link
Copy Markdown
Contributor Author

huccct commented Mar 21, 2025

I think cause of the shadow dom css can not work, so i recommend to replace the shadow dom.

@Herobread
Copy link
Copy Markdown
Owner

I don't really like how isolating shadow dom is, but its impossible to perfectly isolate styles using other ways

for example, when on CS1002 and viewing SSH download dialog without it:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scroll is not scrolling in any dialog

2 participants