-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom MMR IDs #18
Merged
Merged
Custom MMR IDs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate_branch_from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for creating MMRs with custom IDs provided as an argument to functions
create_branch_*
.NOTICE: Calling
create_branch_from
withmmr_id = 0
, creates brand new mmr with size 1 and element equal to hash ofbrave new world
string. Because of thatmmr_id = 0
is reserved and can be only used increate_branch_from
function; in other functions it panics.NOTICE 2: Since absence of MMR in map is indicated by root having value
0
, it would be impossible to distinguish no MMR and MMR with root0
which could allow malicious user to overwrite existing MMR. Therefore,root = 0
is not allowed anywhere.Moved contracts from
l1
folder to herodotus-evm repository.l1/src/L1MessagesSender.sol
->src/core/x-rollup-messaging/outbox/AbstractStarknetMessagesSender.sol
andsrc/core/x-rollup-messaging/outbox/L1ToStarknetMessagesSender.sol
. It was split into two files for better abstractionl1/src/interfaces/*
->src/core/interfaces
orsrc/core/x-rollup-messaging/interfaces