feat: solidity verifier usage example #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for neat example, here is 2 comments i have:
|
rkdud007
reviewed
Sep 17, 2024
examples/eth/src/Prover.sol
Outdated
| return MerkleTrie.get(_key, _proof, _root); | ||
| } | ||
|
|
||
| function verifyInclusionProof(bytes memory _key, bytes memory _value, bytes memory _proof, bytes32 _root) |
There was a problem hiding this comment.
seems this function is not used, can we call this function on the example? or can remove it
There was a problem hiding this comment.
yup, removed, it's doing the same thing under the hood
|
@rkdud007 added docs and a custom settable RPC endpoint which falls back to a good default. |
|
lgtm, thanks for example @merklefruit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple example of using the library to prove the inclusion of a transaction in an Ethereum transaction trie. The example takes in a
txHash, generates a proof by interacting with the CLI binary via FFI, parses it and feeds it to aMerkleTrieverifier after RLP-encoding it correctly.Note: the test has to be run with
forge test --ffito enable FFI usage.