Upgrade rocket to 0.5 #197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxide-auth-rocket/src/lib.rs
Outdated
|
|
||
| impl<'a, 'r> FromRequest<'a, 'r> for OAuthRequest<'r> { | ||
| #[rocket::async_trait] | ||
| impl<'r:'static> FromRequest<'r> for OAuthRequest<'r> { |
There was a problem hiding this comment.
This bound is confusing to me, it seems equivalent to 'r = 'static. Wouldn't this then be only fulfilled at the substitution:
Suggested change
| impl<'r:'static> FromRequest<'r> for OAuthRequest<'r> { | |
| impl FromRequest<'static> for OAuthRequest<'static> { |
I don't think it's very likely that this restriction is intended. In any case it could be written explicitly. Am I missing anything here?
|
I’m still new to lifetimes. I’m having to refer to the docs.
Using the 'static lifetime like 'r:'static is too strict and I was running into the issue "borrowed data escapes the function" and "value may not live long enough" when using does not match the trait implementation.
#[rocket:async_trait]
impl<'r> FromRequest<'r> for Auth0Request<'r>{...}
because request must also be borrowed: &'r Request<'_> or it doesn't match the trait definition. I haven't yet figured out how to use structs with borrowed values in rocket 0.5 yet. I'm sure it's a skill issue. Somehow we have to say that the lifetime of the request outlives the lifetime of the borrowed data.
|
|
Im going to open an other pull request as I have made more changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes/fixes/improves …
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.