Highlight hpilo kernel module requirement #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ilorest_chif.so library seems to handle a lack of the "hpilo" kernel module the same way as a lack of iLO devices, returning "No hpilo devices found" with status 19. This being converted to a "chif" error causes a misleading "Chif driver not found" message if the application is executed on a Linux system having the Chif driver installed, but not having the "hpilo" module loaded. At the point the message is printed, the library was already loaded, indicating it must be correctly present, otherwise it would not have been able to return an error code. Improve user guidance by instead setting an error message similar to the one returned by the library itself, but also pointing out the need for the hpilo kernel module if not executed on Windows. Additionally, highlight this requirement in the README. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
|
The "Pylint static analysis tests are passing above 9.0/10.0" checklist entry is odd, because already the version in the master branch seems to not pass this requirement. Should a specific version of Pylint be used? |
|
Tested: |
rajeevkallur
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ilorest_chif.so library seems to handle a lack of the "hpilo" kernel module the same way as a lack of iLO devices, returning "No hpilo devices found" with status 19.
This being converted to a "chif" error causes a misleading "Chif driver not found" message if the application is executed on a Linux system having the Chif driver installed, but not having the "hpilo" module loaded.
At the point the message is printed, the library was already loaded, indicating it must be correctly present, otherwise it would not have been able to return an error code.
Improve user guidance by instead setting an error message similar to the one returned by the library itself, but also pointing out the need for the hpilo kernel module if not executed on Windows. Additionally, highlight this requirement in the README.
-----Synopsis of Commits Above-----
Please fill out the following when submitting the PR
Status
Additional High Level Description
A few sentences describing the overall goals of the pull request's commits.
#1Dependent PRs
List any PRs that must be merged together. (Tool dependent PRs SHOULD NOT occur.)
Before Status can be set to READY I have completed the following: