feat: inbox/persist search text on reload #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdou6666
requested changes
Feb 24, 2025
| @@ -31,8 +31,24 @@ export const Inbox = () => { | |||
| }); | |||
| const [channels, setChannels] = useState<string[]>([]); | |||
| const [assignment, setAssignment] = useState<AssignedTo>(AssignedTo.ALL); | |||
| const [searchText, setSearchText] = useState(localStorage.getItem("searchText") || ""); | |||
There was a problem hiding this comment.
LGTM 🚀 ! Just a quick suggestion: it would be great to extract the localStorage key for 'searchText' into a constant variable instead of using it as a string directly. This can help prevent any typos in the future and improve maintainability.
yassinedorbozgithub
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Hi @Emnaghz, can you please use a query param from the router in goal to avoid using localStorage
There was a problem hiding this comment.
Hi @Emnaghz, could we please ensure that the logic supports returning to the initial state when a user enters search text and then presses the browser's back button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the inbox page, when a user searches for a text and refreshes the page, the search term was previously not retained. This functionality has now been corrected so that the search term persists even after refreshing the page.
Fixes # #782
Type of change:
Checklist: