Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display synonyms inputs #812

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

abdou6666
Copy link
Member

Motivation

This PR addresses the issue of not displaying synonyms inputs when adding a value

Fixes #776

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code

@marrouchi
Copy link
Contributor

@abdou6666 I have 2 feedbacks:

1- The form component could be used elsewhere, so the entity id is not guaranteed to be passed in the URL.
2- When entity is fetched, you can check on the lookup strategy, if the array contains "keywords" then it can have synonyms. I'm afraid that passing the param "canHaveSynonyms" would/could introduce issues (Single source of truth)

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - NLU Keyword Entity - Synonyms
3 participants