Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root var l2configenv fix #26

Merged
merged 5 commits into from
Jul 22, 2023
Merged

Root var l2configenv fix #26

merged 5 commits into from
Jul 22, 2023

Conversation

lovestaco
Copy link
Contributor

@lovestaco lovestaco commented Jul 22, 2023

What type of MR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Doc Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • ⏩ Revert

Description

This PR fixes the bug where if l2configenv or l2env was absent then l2 -e <l2filepath> would error out.
Adding documentation update using make mkdocs.
Adding PR template and instructions.

Important files to start review from

preprocess. go

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

If documentation update is there then run make mkdocs once PR is in acceptable state.

  • πŸ““ make mkdocs
  • πŸ“œ README.md
  • πŸ™… no documentation needed

@lovestaco lovestaco self-assigned this Jul 22, 2023
@lovestaco lovestaco added the bug Something isn't working label Jul 22, 2023
@lovestaco lovestaco changed the title Globalvar l2configenv fix Root var l2configenv fix Jul 22, 2023
@shrsv shrsv merged commit 87bbcc7 into main Jul 22, 2023
1 check passed
LinceMathew pushed a commit that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants