Update version prompt if l2 binary below v1.5.1 #11

lovestaco · 2023-07-23T10:17:14Z

What type of MR is this?

Description

This MR adds the feature of Adding a version checker for v1.5.1 using semver.
Update prompt for the l2 binary to the latest using l2 -u, prompt will come as a warning + description + button .
Adding Terminal functionalities in Utils and using it in Execute and Gen Snippet.

Mobile & Desktop Screenshots/Recordings

If there is no l2binary installed

If l2binary is less than v1.5.1

Important code file to start Code Review from

Check l2Version.ts

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Are there any post-deployment tasks we need to perform?

Need to prettify the codebase before merging.

- Added utils so next dev can use the teminal functionalities.

- Using getShowLama2Term() in generateCodeSnippet.ts and executeCurrentFile.ts

shrsv · 2023-07-24T04:55:38Z

src/checkL2Version.ts

+  exec("l2 --version", (error, stdout, stderr) => {
+    const versionOutput = stdout.trim();
+    const versionMatch = versionOutput.match(/v(\d+\.\d+\.\d+)/);
+    if (versionMatch && versionMatch.length === 2) {


Why length === 2? We can use capture group to get a triple for (major, minor, patch) as well directly, I think.

I think we can try to use the official semver regex. See here for details. Check the actual regex in action at regex101

Damn never knew so many kinds are there

shrsv · 2023-07-24T04:58:03Z

src/checkL2Version.ts

+  });
+}
+
+function compareL2Versions(currentVersion: string, latestVersion: string) {


I recommend using a library suggested in this SO Answer. Our semver definition is simple now, but there are more changes possible. Best to simply use standardized library for it.

Should be as simple as:

semver.gte('3.4.8', '3.4.7') //true

If we're using this library, then ignore the previous comment about regex*.

Yeah using this

shrsv · 2023-07-24T05:00:58Z

Just curious - have we already integrated the variable suggestion logic (from both l2.env and l2config.env)? If not - we can do it in this MR itself.

shrsv · 2023-07-24T05:19:10Z

src/extension.ts

@@ -34,6 +35,9 @@ export function activate(context: vscode.ExtensionContext) {
  context.subscriptions.push(generateCodeSnippetDisposable);
  console.log(">>> generateCodeSnippetDisposable is now active!");

+  // Automatically check L2 version on extension activation
+  checkL2Version();


So if version is too old, what happens to the variable suggestion? Is it totally dead in older versions?

No in the older version what we were doing is searching the le.env file in front end and suggesting it. So it won't be a problem.

What I am saying is something else.

Say, the extension frontend updates, but the l2 version is still old, what happens?

Remember - VSCode automatically updates extensions quite quickly (I think)

lovestaco · 2023-07-24T14:11:59Z

Just curious - have we already integrated the variable suggestion logic (from both l2.env and l2config.env)? If not - we can do it in this MR itself.

Yes its integrated to main but havent released it yet

#10

shrsv · 2023-07-26T05:10:19Z

src/checkL2Version.ts

 const LAMA2_TERM_NAME = "AutoLama2";
 const UPDATE_MSG = "Support for environment variables.";

-export function checkL2Version() {
+export async function getL2VersionAndUpdatePrompt(minVersionToCheck: string) {


Which function call within this requires async? I don't see any await

Removed this, it wasn't needed

shrsv · 2023-07-26T05:11:22Z

src/checkL2Version.ts

-    });
+      return normalizedVersion;
+    } else {
+      throw new Error("Invalid version format: " + l2Version);


Shall we report to the user - that the version is unknown and probably the extension will not work in full?

We can have a button "Download" to direct them to website.

shrsv · 2023-07-26T05:12:29Z

src/checkL2Version.ts

+      return normalizedVersion;
+    } else {
+      throw new Error("Invalid version format: " + l2Version);
+    }
  } catch (e: any) {
    console.log("Problem while checking for version -> ", e);


We should surface this as a warning - I think.

Especially - what happens when there is no binary in the path?

I think the user ought to know that something is wrong, and that action is needed.

shrsv · 2023-07-26T15:32:30Z

LGTM

lovestaco added 4 commits July 23, 2023 15:05

Automatically check version of binary and prompt update

212a5fa

- Added utils so next dev can use the teminal functionalities.

Rename variables for the CompareL2Version

b6d577a

lock files

2e9f2a0

Use geenric terminal functionalities from utils.

d8060b2

- Using getShowLama2Term() in generateCodeSnippet.ts and executeCurrentFile.ts

lovestaco changed the title ~~Origin/update version prompt~~ Update version prompt if l2 binary below v1.5.1 Jul 24, 2023

shrsv reviewed Jul 24, 2023

View reviewed changes

lovestaco added 4 commits July 24, 2023 19:58

Using semver version check for update prompting

5f40c3e

Using semver library to check versions

c83bb16

Adding read envs from .env support for l2binary < 1.5.1

ab70a59

Adding support for older binary

bb6bd24

shrsv reviewed Jul 26, 2023

View reviewed changes

lovestaco added 3 commits July 26, 2023 18:04

Code refactor for l2version check

9152b41

Prompt to download if l2binary is not present

e2a7a66

Refactoring code to handle the enc suggestions

d69f38a

shrsv merged commit 0d33a12 into main Jul 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update version prompt if l2 binary below v1.5.1 #11

Update version prompt if l2 binary below v1.5.1 #11

lovestaco commented Jul 23, 2023 •

edited

Loading

shrsv Jul 24, 2023

shrsv Jul 24, 2023

lovestaco Jul 24, 2023

shrsv Jul 24, 2023 •

edited

Loading

shrsv Jul 24, 2023

lovestaco Jul 24, 2023

shrsv commented Jul 24, 2023

shrsv Jul 24, 2023

lovestaco Jul 24, 2023

shrsv Jul 24, 2023 •

edited

Loading

lovestaco commented Jul 24, 2023

shrsv Jul 26, 2023

lovestaco Jul 26, 2023

shrsv Jul 26, 2023

lovestaco Jul 26, 2023

shrsv Jul 26, 2023

lovestaco Jul 26, 2023

shrsv commented Jul 26, 2023

Update version prompt if l2 binary below v1.5.1 #11

Update version prompt if l2 binary below v1.5.1 #11

Conversation

lovestaco commented Jul 23, 2023 • edited Loading

What type of MR is this?

Description

Mobile & Desktop Screenshots/Recordings

If there is no l2binary installed

If l2binary is less than v1.5.1

Important code file to start Code Review from

Added tests?

Are there any post-deployment tasks we need to perform?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shrsv Jul 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shrsv commented Jul 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shrsv Jul 24, 2023 • edited Loading

Choose a reason for hiding this comment

lovestaco commented Jul 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shrsv commented Jul 26, 2023

lovestaco commented Jul 23, 2023 •

edited

Loading

shrsv Jul 24, 2023 •

edited

Loading

shrsv Jul 24, 2023 •

edited

Loading