Skip to content

[release] 2.1.2 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hye0njuoo wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −4
Open

[release] 2.1.2 #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Hilingual.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@
BUNDLE_NAME = "Hilingual-Dev";
CODE_SIGN_ENTITLEMENTS = Hilingual/Hilingual.entitlements;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 2025021501;
CURRENT_PROJECT_VERSION = 2025022201;
DEVELOPMENT_TEAM = C9XX799UJH;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = Hilingual/Info.plist;
Expand All @@ -278,7 +278,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 2.1.3;
MARKETING_VERSION = 2.1.2;
Copy link

@coderabbitai coderabbitai bot Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

MARKETING_VERSION 다운그레이드로 인한 develop 브랜치 버전 역행 주의

AI 요약에 따르면 MARKETING_VERSION이 2.1.3 → 2.1.2로 변경되었습니다. 이 PR이 release/2.1.2 → develop으로 병합되면, develop 브랜치의 마케팅 버전이 2.1.3에서 2.1.2로 낮아집니다.

Gitflow 관행상 release 브랜치를 develop에 병합한 후에는 develop의 버전을 다음 릴리즈(예: 2.1.3 또는 2.2.0)로 즉시 재인상해야 합니다. 병합 후 별도 커밋으로 버전 업 작업이 계획되어 있는지 확인해 주세요.

Also applies to: 319-319

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@Hilingual.xcodeproj/project.pbxproj` at line 281, PR changes
MARKETING_VERSION from 2.1.3 to 2.1.2 which will downgrade develop when merging
release/2.1.2→develop; after merging, immediately re-bump MARKETING_VERSION in
the Xcode project (project.pbxproj MARKETING_VERSION) on develop to the correct
next value (e.g., 2.1.3 or 2.2.0) in a separate commit, or confirm an existing
follow-up commit is planned to do this; update any related build/version
constants if present to match the new marketing version.

PRODUCT_BUNDLE_IDENTIFIER = "com.Hilingual$(BUNDLE_ID_SUFFIX)";
PRODUCT_NAME = "Hilingual-Dev";
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand All @@ -300,7 +300,7 @@
BUNDLE_NAME = Hilingual;
CODE_SIGN_ENTITLEMENTS = Hilingual/Hilingual.entitlements;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 2025021501;
CURRENT_PROJECT_VERSION = 2025022201;
DEVELOPMENT_TEAM = C9XX799UJH;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = Hilingual/Info.plist;
Expand All @@ -316,7 +316,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 2.1.3;
MARKETING_VERSION = 2.1.2;
PRODUCT_BUNDLE_IDENTIFIER = "com.Hilingual$(BUNDLE_ID_SUFFIX)";
PRODUCT_NAME = "$(TARGET_NAME)";
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand Down