Update code contribution instructions and Nox sessions #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namurphy
changed the title
namurphy
commented
Jun 28, 2024
nabobalis
reviewed
Sep 4, 2024
nabobalis
force-pushed
the
contributing-instructions-update
branch
3 times, most recently
from
b880b05
to
6ede75f
Compare
nabobalis
reviewed
Sep 6, 2024
| @@ -605,7 +605,7 @@ def calculate_TE_errors(map1, map2, T_e, EM, model_ratio, tresp1, tresp2, Trange | |||
| return T_error, EMerror, K1, K2 | |||
|
|
|||
|
|
|||
| def make_results_maps(hdr1, hdr2, T_e, EM, T_error, EMerror, mask): # noqa: ARG001 | |||
| def make_results_maps(hdr1, hdr2, T_e, EM, T_error, EMerror): | |||
There was a problem hiding this comment.
This was unused, so I removed it.
nabobalis
reviewed
Sep 6, 2024
nabobalis
force-pushed
the
contributing-instructions-update
branch
2 times, most recently
from
54b1768
to
dd183f6
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
nabobalis
force-pushed
the
contributing-instructions-update
branch
from
dd183f6
to
9a2843d
Compare
nabobalis
force-pushed
the
contributing-instructions-update
branch
from
9a2843d
to
61d3558
Compare
nabobalis
reviewed
Sep 6, 2024
nabobalis
reviewed
Sep 6, 2024
|
|
||
| - repo: https://github.com/nbQA-dev/nbQA | ||
| rev: 1.8.7 | ||
| hooks: | ||
| - id: nbqa-check-ast | ||
| name: validate Python notebooks | ||
| - id: nbqa-ruff |
There was a problem hiding this comment.
ruff handles notebook linting now. I don't think this is needed anymore.
nabobalis
approved these changes
Sep 6, 2024
nabobalis
force-pushed
the
contributing-instructions-update
branch
from
5ce85cf
to
78baa2a
Compare
wtbarnes
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nox -s docsin the top-level directory.nox -s tests. We can also run tests just withnoxsince we set thetestsenvironment as the default.