Add Linux Support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gojig.py contains the following lines to get the binary name: We should change this to include the system name too. And we should make sure these are all lowercase: Can you please rename the existing binaries for mac to include |
kadircancetin
force-pushed
the
linux-support
branch
from
8f0f02e
to
3870d96
Compare
kadircancetin
commented
Sep 25, 2022
|
|
||
| # Checkout v3.8.1 | ||
| WORKDIR "/Users/fergal/go-algorand/" | ||
| RUN git checkout v3.8.1-stable |
There was a problem hiding this comment.
I can not build with v3.9 :/ . Also can not build with in my host machine as well.
There was a problem hiding this comment.
# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function 'sqlite3SelectNew':
sqlite3-binding.c:123303:10: warning: function may return address of local variable [-Wreturn-local-addr]
123303 | return pNew;
| ^~~~
sqlite3-binding.c:123263:10: note: declared here
123263 | Select standin;
| ^~~~~~~
# github.com/Hipo/algojig
./main.go:163:43: not enough arguments in call to verify.TxnGroup
have ([]transactions.SignedTxn, bookkeeping.BlockHeader, verify.VerifiedTransactionCache)
want ([]transactions.SignedTxn, bookkeeping.BlockHeader, verify.VerifiedTransactionCache, logic.LedgerForSignature)
This is the exception I got when I try v3.9.x. Same exception without docker.
|
also, not all tests are passed. I think it is not directly related to the executable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Linux binary. I test it with
Because I don't know how can I support more than one binary, I replace mac binary.
@fergalwalsh please lead me about supporting multiple platforms.