-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gueltig and Qualitaet to BusinessObject #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich fände es noch schoen, wenn wir noch in den docstrings genauer beschreiben, wo das herkommt also was die idee hinter den änderungne ist. ich blicks ja nur, weil ich die idee kenne :)
BO4E/BO/BusinessObject.cs
Outdated
)] | ||
[ProtoMember(201)] | ||
[JsonPropertyOrder(201)] | ||
public COM.Zeitraum? Gueltig { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wie wäre es mit gueltigkeitszeitraum als name?
/// <summary> | ||
/// Defines the validity of a business object in terms of time (maybe multiple versions exist) | ||
/// </summary> | ||
[JsonProperty( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kannst du auch den system.text.json property name explizit spezifizieren?
Der Name Gültigkeit ist leider schon in einigen anderen BOs definiert (zudem mal als Zeitraum und mal als List), wer einen besseren Namen hat gern vorschlagen.