Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Wiederholbarkeiten (FV2204) #96

Open
1 of 2 tasks
hf-aschloegl opened this issue Nov 30, 2021 · 2 comments · Fixed by #120
Open
1 of 2 tasks

Implement Wiederholbarkeiten (FV2204) #96

hf-aschloegl opened this issue Nov 30, 2021 · 2 comments · Fixed by #120
Assignees
@schachmett

Comments

@hf-aschloegl
Copy link
Collaborator

hf-aschloegl commented Nov 30, 2021 •
edited by hf-kklein
Loading

There are two different types of Wiederholbarkeiten:

  • Conditions with numbers greater than [2000]
  • Packages like [3P1...0]

Only Distinction

ahbicht/src/ahbicht/condition_node_distinction.py

Line 19 in 2891432

def derive_condition_node_type(condition_key: str) -> ConditionNodeType:

grafik
@hf-aschloegl hf-aschloegl changed the title Implement Wiederholbarkeiten (FV2022) Implement Wiederholbarkeiten (FV2204) Nov 30, 2021
@hf-kklein hf-kklein mentioned this issue Jan 28, 2022
Closed
@hf-kklein hf-kklein self-assigned this Feb 2, 2022
@hf-kklein
Copy link
Contributor

#120 addresses the parsing part. However I don't know how to proceed from there. What shall we do with the repeatability?

@hf-kklein hf-kklein linked a pull request Feb 22, 2022 that will close this issue
✨Parse Repeatability in Packages: [123P4..5] (without using it yet) #120
Merged
@hf-kklein hf-kklein reopened this Feb 25, 2022
@hf-kklein hf-kklein assigned schachmett and unassigned hf-kklein Feb 25, 2022
@hf-kklein
Copy link
Contributor

Hi Simon, nachdem #120 jetzt gemerged ist, gibt es schonmal eine Klasse und etwas Code bei dem du ansetzen kannst. Ich glaube mittlerweile überschneiden sich die noch verbliebenen Wiederholbarkeiten von hier mit den #39 number ranges.

@schachmett schachmett mentioned this issue Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schachmett schachmett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨Parse Repeatability in Packages: [123P4..5] (without using it yet) Hochfrequenz/ahbicht
3 participants
@hf-kklein @schachmett @hf-aschloegl