Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Implement repeatability constraints #136

Merged
merged 15 commits into from
May 16, 2022
Merged

✨Implement repeatability constraints #136

merged 15 commits into from
May 16, 2022

Conversation

schachmett
Copy link
Contributor

Will implement repeatability constraints (number range 2000-2499, see image)
See #96 #39

test

@schachmett schachmett marked this pull request as draft March 1, 2022 16:32
@schachmett schachmett requested a review from a team March 22, 2022 13:16
hf-kklein
hf-kklein requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Simon, könntest du da noch ein paar Unittests für schreiben? Wenn du nen Breakpoint an die angepassten Stellen setzt müsste das recht einfach möglich sein, die Tests zu finden, die an deinem Code vorbeikommen.

Die kannst du dann adaptieren.

@schachmett
Copy link
Contributor Author

Ich habe meine Testprobleme in VS Code gelöst, kann ich morgen berichten / auf stackoverflow posten.
Jetzt muss ich nur noch die Tests tatsächlich einmal abklappern.

@schachmett schachmett marked this pull request as ready for review May 3, 2022 13:46
@schachmett schachmett requested a review from a team May 3, 2022 13:47
hf-kklein
hf-kklein approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 war jetzt doch weniger als anfangs gedacht ;)

@hf-kklein hf-kklein requested a review from a team May 3, 2022 14:00
hf-aschloegl
hf-aschloegl approved these changes May 4, 2022
View reviewed changes
README.rst Outdated Show resolved Hide resolved
schachmett and others added 3 commits May 13, 2022 08:40
@schachmett @hf-aschloegl
Update README.rst
b1d2bbc 
Co-authored-by: Annika <[email protected]>
@schachmett
Merge branch 'main' into repeatability_resolver
227b014
@hf-kklein
Fix Doc Build (#167)
7e45e3f 
* 🖊 Typo: "occurence"➡"occurrence"

* Fix table column with in README.rst

* Remove maus_provider from ahbicht docs

this is because in #161 `tox -e docs` was not run
@schachmett schachmett merged commit d3c2d6d into main May 16, 2022
@hf-kklein hf-kklein deleted the repeatability_resolver branch May 16, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreddyFox892 FreddyFox892 FreddyFox892 left review comments

@hf-kklein hf-kklein hf-kklein approved these changes

@hf-aschloegl hf-aschloegl hf-aschloegl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schachmett @hf-kklein @hf-aschloegl @FreddyFox892