Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move optional dependencies from dev_requirements to pyproject.toml #474

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Move optional dependencies from dev_requirements to pyproject.toml #474

merged 15 commits into from
Sep 24, 2024

Conversation

FreddyFox892
Copy link
Contributor

No description provided.

@FreddyFox892
Copy link
Contributor Author

@hf-kklein Weißt du wie ich das mit den Packages Grade ziehe?
Hab einige Typos mittels spellchech entfernt und jetzt meckert der deswegen

@hf-kklein
Copy link
Contributor

@FreddyFox892 weil das repo hier eine historie hat/schon etwas älter ist, ist der umstieg ein bisschen schwieriger. ich würde vorschlagen wir gehen schritt für schritt vor (mit kleineren schritten).
du machst hier quasi einen sprung von "unser setup 2020" nach "unser setup 2024", während bei anderen repos es eher so war: "setup von 2023 auf setup 2024" umstellen.

Vorschlag:
Erst tauschen wir die setuptools/setup.cfg setup durch hatchling+pyproject.toml aus, behalten aber die dev-requirements. Dann, in einem zweiten PR, switchen wir die dev-requirements in die toml.
kleinere schritte bringen weniger fehler auf einmal. das ist ws. einfacher zu managen.

hf-kklein
hf-kklein reviewed Sep 20, 2024
View reviewed changes
pyproject.toml Outdated
@@ -66,13 +75,12 @@ dev = [
[project.urls]
Changelog = "https://github.com/Hochfrequenz/ahbicht/releases"
Homepage = "https://github.com/Hochfrequenz/ahbicht"
Documetnation = "https://ahbicht.readthedocs.io/en/latest/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Documetnation = "https://ahbicht.readthedocs.io/en/latest/"
Documentation = "https://ahbicht.readthedocs.io/en/latest/"

@hf-krechan hf-krechan enabled auto-merge (squash) September 24, 2024 06:29
@hf-krechan hf-krechan merged commit 78c1851 into main Sep 24, 2024
18 checks passed
@hf-krechan hf-krechan deleted the FST/UpdatePyProjectTomlSetup branch September 24, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-krechan hf-krechan hf-krechan approved these changes

@hf-kklein hf-kklein Awaiting requested review from hf-kklein

Assignees

@FreddyFox892 FreddyFox892

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FreddyFox892 @hf-kklein @hf-krechan