ignore ahb tables where no pruefi is provided #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaDaniel
deleted the
356-kohlrahbi-crashes-with-fv2504-documents-collector-should-not-be-empty
branch
hf-krechan
reviewed
Jul 11, 2024
Comment on lines
+192
to
+194
| pattern = r"Prüfidentifikator(?:\t){0,10}\t\d+" | ||
| # "matches "Prüfidentifikator" followed by at least 1 tab separated numbers, max 11 pruefis is chosen arbitrarily | ||
| return bool(re.search(pattern, table.row_cells(0)[-1].text)) |
There was a problem hiding this comment.
@hf-kklein gab es hier nicht noch ein anderes pattern was das pattern irgendwie compiled hat?
Ziel war es dass das regex nur einmal ausgeführt werden muss.
Oft haben wir das pattern global ausgelagert und dann in der Funktion nur angewendet.
Weißt du was ich meine?
There was a problem hiding this comment.
my_pattern = re.comile(r"Prüfidentifikator(?:\t){0,10}\t\d+")
und dann mypattern.search(...)
There was a problem hiding this comment.
bringt dann was, wenn die funktion sehr oft aufgerufen wird. wobei auch so der regex-teil einen internen cache hat iirc.
There was a problem hiding this comment.
Ah okay. Die Funktion wir in jeder Tabelle aufgerufen. Aber wenn sie einen internen Cache hat passt das.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.