Repository navigation
Rescale the balanced objective and stop falsely converging - #106
Merged
Merged
Conversation
cover_transversal(PowerMean{p}(), A; target) evaluates its objective
divided by target^p, so the weights are (r/target)^p rather than r^p.
Ratios far below one no longer underflow for large p, and the range
check now rejects target^(-p) that would overflow.
A Newton step at the resolution of the arithmetic no longer reports
convergence when the relative reduced gradient exceeds tol: roundoff in
the groups' gradients can hide a descent direction (for example, the
common scale of a block whose internal weights are ~1e22). The solve
now stops with stalled = true and a warning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 98.34% 98.40% +0.06%
==========================================
Files 25 25
Lines 7536 7541 +5
==========================================
+ Hits 7411 7421 +10
+ Misses 125 120 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cover_transversal(PowerMean{p}(), A; target)evaluates its objective divided bytarget^p, so the weights are(r/target)^prather thanr^p. Ratios far below one no longer underflow for large p, and the range check now rejectstarget^(-p)that would overflow.A Newton step at the resolution of the arithmetic no longer reports convergence when the relative reduced gradient exceeds tol: roundoff in the groups' gradients can hide a descent direction (for example, the common scale of a block whose internal weights are ~1e22). The solve now stops with stalled = true and a warning.