Repository navigation
Define each solver keyword default in one place - #108
Merged
Merged
Conversation
The public solver functions forward their keywords to one options
function per solver family, which holds the defaults:
`_powermean_options` for the PowerMean soft covers and `noise_cover`,
`_auglag_options` (with `_auglag_linsolve_options`) for the minimal
covers, `cover_transversal`, and the AbsLog{2} soft covers, and
`_balanced_options` for `cover_transversal(::PowerMean, A)`. A keyword
outside a function's documented set, including the internal keywords of
the workers, throws a MethodError before any work is done.
Docstrings interpolate the constants behind their stated defaults, so
the documented values follow the code. `soft_covers.jl` is included
after `minimal_covers.jl` so that those constants are defined first.
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 26 26
Lines 8222 8230 +8
=======================================
+ Hits 8085 8093 +8
Misses 137 137 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public solver functions forward their keywords to one options function per solver family, which holds the defaults:
_powermean_optionsfor the PowerMean soft covers andnoise_cover,_auglag_options(with_auglag_linsolve_options) for the minimal covers,cover_transversal, and the AbsLog{2} soft covers, and_balanced_optionsforcover_transversal(::PowerMean, A). A keyword outside a function's documented set, including the internal keywords of the workers, throws a MethodError before any work is done.Docstrings interpolate the constants behind their stated defaults, so the documented values follow the code.
soft_covers.jlis included afterminimal_covers.jlso that those constants are defined first.Assisted-by: Claude Opus 5.5 noreply@anthropic.com