Repository navigation
Conversation
Changes that let every Float64 entry point compile with `juliac --trim=safe`, with results unchanged: - `_eachindex` gains a six-argument method, and calls of `eachindex` on three or more arrays use it. - The minimal-cover statistics have one concrete `NamedTuple` type: traces are vectors, and a `polished` flag with a placeholder `polish` entry stands in for the active-set finish when it does not run. - `_LaplacianCG` records its fallback factorization type as a parameter, and `_TreeLaplacian` is built behind a function barrier. - `_symmetric_from_upper` assembles the symmetric matrix directly, since the `SparseArrays` transpose takes an unspecialized `::Function`. - `noise_cover` makes one `_powermean_solve!` call per type of `terms` and builds its long error message without long interpolation. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 98.33% 98.34%
=======================================
Files 26 26
Lines 8247 8289 +42
=======================================
+ Hits 8110 8152 +42
Misses 137 137 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`FB` appears only in `Union{Nothing,FB}`, so the default outer
constructor left it unbound, which Aqua reports on Julia 1.10.
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes that let every Float64 entry point compile with
juliac --trim=safe, with results unchanged:_eachindexgains a six-argument method, and calls ofeachindexon three or more arrays use it.NamedTupletype: traces are vectors, and apolishedflag with a placeholderpolishentry stands in for the active-set finish when it does not run._LaplacianCGrecords its fallback factorization type as a parameter, and_TreeLaplacianis built behind a function barrier._symmetric_from_upperassembles the symmetric matrix directly, since theSparseArraystranspose takes an unspecialized::Function.noise_covermakes one_powermean_solve!call per type oftermsand builds its long error message without long interpolation.Assisted-by: Claude Opus 5.5 noreply@anthropic.com