Skip to content

Make the solvers compile under juliac --trim=safe - #111

Merged
timholy merged 2 commits into
mainfrom
teh/trim
Nov 3, 2026
Merged

timholy merged 2 commits into
mainfrom
teh/trim

Conversation

@timholy

@timholy timholy commented Nov 2, 2026

Copy link
Copy Markdown
Member

Changes that let every Float64 entry point compile with juliac --trim=safe, with results unchanged:

  • _eachindex gains a six-argument method, and calls of eachindex on three or more arrays use it.
  • The minimal-cover statistics have one concrete NamedTuple type: traces are vectors, and a polished flag with a placeholder polish entry stands in for the active-set finish when it does not run.
  • _LaplacianCG records its fallback factorization type as a parameter, and _TreeLaplacian is built behind a function barrier.
  • _symmetric_from_upper assembles the symmetric matrix directly, since the SparseArrays transpose takes an unspecialized ::Function.
  • noise_cover makes one _powermean_solve! call per type of terms and builds its long error message without long interpolation.

Assisted-by: Claude Opus 5.5 noreply@anthropic.com

Changes that let every Float64 entry point compile with
`juliac --trim=safe`, with results unchanged:

- `_eachindex` gains a six-argument method, and calls of `eachindex`
  on three or more arrays use it.
- The minimal-cover statistics have one concrete `NamedTuple` type:
  traces are vectors, and a `polished` flag with a placeholder `polish`
  entry stands in for the active-set finish when it does not run.
- `_LaplacianCG` records its fallback factorization type as a parameter,
  and `_TreeLaplacian` is built behind a function barrier.
- `_symmetric_from_upper` assembles the symmetric matrix directly, since
  the `SparseArrays` transpose takes an unspecialized `::Function`.
- `noise_cover` makes one `_powermean_solve!` call per type of `terms`
  and builds its long error message without long interpolation.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.34%. Comparing base (964397d) to head (1b1baf0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   98.33%   98.34%           
=======================================
  Files          26       26           
  Lines        8247     8289   +42     
=======================================
+ Hits         8110     8152   +42     
  Misses        137      137           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

`FB` appears only in `Union{Nothing,FB}`, so the default outer
constructor left it unbound, which Aqua reports on Julia 1.10.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
@timholy
timholy merged commit 4c72049 into main Nov 3, 2026
7 checks passed
@timholy
timholy deleted the teh/trim branch November 3, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant