Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The description clearly explains the Swedish localization, affected areas, validation steps, and known test behavior. It is directly related to the changeset. |
| Title check | |
The title clearly and concisely identifies the main change: adding Swedish localization. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
287d8ac9-ffa3-48b4-be8e-96b5bca8f6db
📒 Files selected for processing: 9
Homebrew/Localizable.xcstringsSources/BrewFeatureConfig/Resources/Localizable.xcstringsSources/BrewFeatureConsole/Resources/Localizable.xcstringsSources/BrewFeatureDiscover/Resources/Localizable.xcstringsSources/BrewFeatureDoctor/Resources/Localizable.xcstringsSources/BrewFeatureInstalled/Resources/Localizable.xcstringsSources/BrewFeatureSelfUpgrade/Resources/Localizable.xcstringsSources/BrewFeatureServices/Resources/Localizable.xcstringsSources/BrewUIComponents/Resources/Localizable.xcstrings
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout: 3
- GitHub Check: UI tests
- GitHub Check: Build + unit/integration tests
- GitHub Check: Live end-to-end canaries
| "stringUnit" : { | ||
| "state" : "translated", | ||
| "value" : "— %@" | ||
| "value" : "%@" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve the running-status separator.
ConsoleStatusBar.summaryText localizes Text("— \(shortLabel)", ...) through the "— %@" key. These values replace the separator with %@, so Spanish, Chinese, and Swedish running statuses lose the dash. Keep — %@ in these values.
Also applies to: 613-613, 619-620, 625-625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Add a complete Swedish (
sv) localization for BrewUI's main application, shared components, configuration, console, discovery, diagnostics, installed packages, self-upgrade, and services views. Swedish can now be selected as an app language; untranslated fallback is no longer needed for these catalogs.Validation
scripts/localize verifyscripts/localize statusreportssv 278 translated 0 untranslatedscripts/testwas run. Two Discover number-format assertions fail under this machine's Swedish system locale; the identical failures reproduce on unmodifiedmain.Swedish review:
svlang skrivreglerfound no writing-rule violations; Hunspell results were reviewed as Homebrew, BrewUI, brew, Brewfile, and other project terms.Catalog review: JSON parsing, duplicate-key detection, and source/Swedish placeholder comparison passed.
gitleaks protect --staged --redact --source .I followed the conventions and workflow, checked for duplicate PRs and kept this change focused.
Automated regression coverage is impractical for localization-only catalog content; catalog validation and the full test suite were run instead.
Screenshots
Not applicable. This changes localized catalog text only; it does not change layouts or interactions.
AI assistance
Codex assisted with Swedish draft translations. The resulting catalogs were checked against the source strings and their UI comments, then validated with the project verifier, tests, Swedish writing-rule checks, placeholder checks, and Gitleaks.