Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onyx: update Sequoia handling #177498

Closed
wants to merge 1 commit into from
Closed

onyx: update Sequoia handling #177498

wants to merge 1 commit into from

Conversation

p-linnane
Copy link
Member

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


This PR adds handling to the OnyX cask for macOS Sequoia. Livecheck is currently returning the latest version on Sonoma as the upcoming version for Sequoia.

There is no existing release for Sequoia, but the releases only run on their specified OS, so this should be fine.

Signed-off-by: Patrick Linnane <[email protected]>
@p-linnane p-linnane requested a review from a team June 21, 2024 22:48
@p-linnane p-linnane mentioned this pull request Jun 21, 2024
@Bo98
Copy link
Member

Bo98 commented Jun 21, 2024

We should update the livecheck to match e.g. https://www.titanium-software.fr/download/15/OnyX.plist and have it fixed like the URLs are.

@Rylan12
Copy link
Member

Rylan12 commented Jun 21, 2024

Maybe I'm misunderstanding (also I've not been around for a while so we might do things differently now), but it seems fine to me on Sonoma?

brew livecheck onyx
onyx: 4.5.9 ==> 4.5.9

It feels weird to add a URL that doesn't exist, I think Sequoia users should have a "formula doesn't work on this version" error not an "invalid url" type error

@Bo98
Copy link
Member

Bo98 commented Jun 21, 2024

Maybe I'm misunderstanding (also I've not been around for a while so we might do things differently now), but it seems fine to me on Sonoma?

The livecheck is based on MacOS.version interpolation and #177487 was presumably created on a machine with macOS 15 installed.

regex(/>\s*OnyX\s+v?(\d+(?:\.\d+)+)\s+for\s+[\w\s.-]*\s+#{MacOS.version}\s*</i)

In reality we probably want the livecheck to be aligned with what the URL uses.

@krehel
Copy link
Member

krehel commented Jun 21, 2024

The livecheck is based on MacOS.version interpolation and #177487 was presumably created on a machine with macOS 15 installed.

Yeah, I was using Sequoia when I opened the PR.

@p-linnane
Copy link
Member Author

Happy to refactor however we think works best. This cask has been rough to deal with given the versioning.

@bevanjkay
Copy link
Member

Because it's scoped to versions, do we just scope the livecheck to each version too?

@p-linnane p-linnane closed this Jun 28, 2024
@p-linnane p-linnane deleted the onyx-sequoia branch June 28, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants