-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acronis-true-image 41592: improve uninstall and implement zap #190984
base: master
Are you sure you want to change the base?
Conversation
6b9f8e6
to
e27eae3
Compare
d87aac9
to
7ed6a36
Compare
7ed6a36
to
1088fee
Compare
What is the reason to depends on |
The cleanup tool is downloaded separately from a different location. |
1088fee
to
0747336
Compare
Updated to resolve conflicts with others' efforts to implement uninstall + zap. |
Uses `acronis-true-image-cleanup-tool`
0747336
to
5da332e
Compare
@daeho-ro Will anyone review this? |
signal: [ | ||
["TERM", "com.acronis.CyberProtectHomeOffice"], | ||
["TERM", "com.acronis.CyberProtectHomeOffice.FinderSyncExt"], | ||
["TERM", "com.acronis.CyberProtectHomeOffice.help"], | ||
["TERM", "com.acronis.CyberProtectHomeOffice.monitor"], | ||
["TERM", "com.acronis.escyberprotect"], | ||
["KILL", "com.acronis.CyberProtectHomeOffice"], | ||
["KILL", "com.acronis.CyberProtectHomeOffice.FinderSyncExt"], | ||
["KILL", "com.acronis.CyberProtectHomeOffice.help"], | ||
["KILL", "com.acronis.CyberProtectHomeOffice.monitor"], | ||
["KILL", "com.acronis.escyberprotect"], | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to call these IDs in three separate places?
Currently with uninstall quit
, and then TERM
and KILL
in the signal
stanza.
Uses
acronis-true-image-cleanup-tool
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.