Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acronis-true-image 41592: improve uninstall and implement zap #190984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unshare
Copy link
Contributor

@unshare unshare commented Nov 5, 2024

Uses acronis-true-image-cleanup-tool

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@unshare unshare mentioned this pull request Nov 5, 2024
8 tasks
@unshare unshare changed the title acronis-true-image 41592: implement zap stanza acronis-true-image 41592: improve uninstall and implement zap Nov 5, 2024
@unshare unshare force-pushed the acronis-true-image-with-zap branch 3 times, most recently from d87aac9 to 7ed6a36 Compare November 6, 2024 12:36
@unshare unshare marked this pull request as ready for review November 6, 2024 12:42
@daeho-ro
Copy link
Member

What is the reason to depends on acronis-true-image-cleanup-tool cask?

@unshare
Copy link
Contributor Author

unshare commented Nov 11, 2024

What is the reason to depends on acronis-true-image-cleanup-tool cask?

The cleanup tool is downloaded separately from a different location.
It is the ultimate cleanup tool most suitable for the zap and it is maintained by the upstream vendor.
For cleanup tool to be available at the zap time, it's declared as a dependency of the main application cask.

@unshare
Copy link
Contributor Author

unshare commented Nov 12, 2024

Updated to resolve conflicts with others' efforts to implement uninstall + zap.
The procedure proposed here is much more robust and it uses vendor-supplied tool for this specific purpose.

@unshare
Copy link
Contributor Author

unshare commented Nov 21, 2024

@daeho-ro Will anyone review this?

Comment on lines +42 to +53
signal: [
["TERM", "com.acronis.CyberProtectHomeOffice"],
["TERM", "com.acronis.CyberProtectHomeOffice.FinderSyncExt"],
["TERM", "com.acronis.CyberProtectHomeOffice.help"],
["TERM", "com.acronis.CyberProtectHomeOffice.monitor"],
["TERM", "com.acronis.escyberprotect"],
["KILL", "com.acronis.CyberProtectHomeOffice"],
["KILL", "com.acronis.CyberProtectHomeOffice.FinderSyncExt"],
["KILL", "com.acronis.CyberProtectHomeOffice.help"],
["KILL", "com.acronis.CyberProtectHomeOffice.monitor"],
["KILL", "com.acronis.escyberprotect"],
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to call these IDs in three separate places?
Currently with uninstall quit, and then TERM and KILL in the signal stanza.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants