Skip to content

trunk-ng 0.17.10 (new formula) #150913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Oct 14, 2023

This adds a new formula for trunk-ng, a fork of trunk.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This adds a new formula for trunk-ng, a fork of trunk.
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 14, 2023
@ctron
Copy link
Contributor Author

ctron commented Oct 14, 2023

I am stuck with this and need some help. According to the docs, I ran the audit command, and it returned nothing:

➜  t git:(add-trunk-ng) brew audit trunk-ng --online --new-formula
➜  t git:(add-trunk-ng) 

Now it looks that the result in the CI is different:

Full audit trunk-ng --online --new-formula output
  trunk-ng
    * GitHub fork (not canonical repository)
  Error: 1 problem in 1 formula detected.

However, this also is correct. This is a fork or the original project. However, that's just what it is.

@chenrui333
Copy link
Member

can you show the brew config?

@chenrui333
Copy link
Member

This adds a new formula for trunk-ng, a fork of trunk.

also did you get endorsement from the original fork (that one seems still in active dev)? and in terms of the github stats, it is also low as well.

@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333 chenrui333 added the stale No recent activity label Oct 15, 2023
@ctron
Copy link
Contributor Author

ctron commented Oct 16, 2023

This adds a new formula for trunk-ng, a fork of trunk.

also did you get endorsement from the original fork (that one seems still in active dev)? and in terms of the github stats, it is also low as well.

The problem with the original project is, that none of the contributors is responsive anymore. Still, the original author stated that he's ok with that (trunk-rs/trunk#588 (comment)):

@ctron I can appreciate where you are coming from. Folks often times have a great deal of urgency when it comes to fixes that they need for their projects and such. YOU SHOULD do whatever it is that you need to do in order to get to a stable point. Host a build yourself. Whatever. Its fine. This is open source.


can you show the brew config?

As I am currently at a conference, I can't provide this before Thursday.

@github-actions github-actions bot removed the stale No recent activity label Oct 16, 2023
@SMillerDev
Copy link
Member

The problem with the original project is, that none of the contributors is responsive anymore. Still, the original author stated that he's ok with that (trunk-rs/trunk#588 (comment)):

That reads as a "sure you can fork, I don't care" rather than a "yes, you are the new upstream now I am giving up". So that would leave us with the exact situation the audit is meant to catch: "who is the real developer".

If you are never going to upstream changes anymore, you can unfork your repo. If you are, it shouldn't be in Homebrew/core.

@ctron
Copy link
Contributor Author

ctron commented Oct 17, 2023

If you are never going to upstream changes anymore, you can unfork your repo. If you are, it shouldn't be in Homebrew/core.

I believe that "unforking" the repository is just wrong. It is a fork of that original project and keeping that information is kind of an attribution to the original author.

I don't plan to bring changes to the original project at this point, just because I can't. On the other side, I am not sure what the future will bring. So I wouldn't rule that out either.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 8, 2023
@ctron
Copy link
Contributor Author

ctron commented Nov 8, 2023

Activity

@github-actions github-actions bot removed the stale No recent activity label Nov 8, 2023
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 29, 2023
@ctron
Copy link
Contributor Author

ctron commented Nov 30, 2023

Activity

@github-actions github-actions bot removed the stale No recent activity label Nov 30, 2023
@fxcoudert
Copy link
Member

I agree with @SMillerDev here, and this is a fork with not enough notable activity, and not the “current upstream”, so not really suitable for homebrew-core. Thank you for your pull request, we are going to decline at this point. This is not a decision on the merits of the software, but we cannot distribute every single piece of software and have to draw a line on “notability” somewhere. Of course, we would be happy to reconsider in the future.

Please consider hosting it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@fxcoudert fxcoudert closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants