-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
trunk-ng 0.17.10 (new formula) #150913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunk-ng 0.17.10 (new formula) #150913
Conversation
This adds a new formula for trunk-ng, a fork of trunk.
I am stuck with this and need some help. According to the docs, I ran the audit command, and it returned nothing:
Now it looks that the result in the CI is different:
However, this also is correct. This is a fork or the original project. However, that's just what it is. |
can you show the |
also did you get endorsement from the original fork (that one seems still in active dev)? and in terms of the github stats, it is also low as well. |
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
The problem with the original project is, that none of the contributors is responsive anymore. Still, the original author stated that he's ok with that (trunk-rs/trunk#588 (comment)):
As I am currently at a conference, I can't provide this before Thursday. |
That reads as a "sure you can fork, I don't care" rather than a "yes, you are the new upstream now I am giving up". So that would leave us with the exact situation the audit is meant to catch: "who is the real developer". If you are never going to upstream changes anymore, you can unfork your repo. If you are, it shouldn't be in Homebrew/core. |
I believe that "unforking" the repository is just wrong. It is a fork of that original project and keeping that information is kind of an attribution to the original author. I don't plan to bring changes to the original project at this point, just because I can't. On the other side, I am not sure what the future will bring. So I wouldn't rule that out either. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Activity |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Activity |
I agree with @SMillerDev here, and this is a fork with not enough notable activity, and not the “current upstream”, so not really suitable for homebrew-core. Thank you for your pull request, we are going to decline at this point. This is not a decision on the merits of the software, but we cannot distribute every single piece of software and have to draw a line on “notability” somewhere. Of course, we would be happy to reconsider in the future. Please consider hosting it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap |
This adds a new formula for trunk-ng, a fork of trunk.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?