Skip to content

uv: add bzip2 dependency on Linux#170008

Merged
chenrui333 merged 1 commit intomasterfrom
uv-bzip2
Apr 24, 2024
Merged

uv: add bzip2 dependency on Linux#170008
chenrui333 merged 1 commit intomasterfrom
uv-bzip2

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Apr 24, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Missing dependency in #170004.

https://github.com/Homebrew/homebrew-core/actions/runs/8821814120/job/24218662899#step:5:143

Undeclared dependencies with linkage:
  bzip2

macOS will need to use bundled copy as neither Xcode nor brew bzip2 includes pkgconfig files.

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Apr 24, 2024
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Apr 24, 2024
Add comment on reason why macOS doesn't have a dependency (via
`uses_from_macos` or from `depends_on`)

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 chenrui333 enabled auto-merge April 24, 2024 20:27
@chenrui333 chenrui333 added this pull request to the merge queue Apr 24, 2024
Merged via the queue into master with commit c7a00f2 Apr 24, 2024
@chenrui333 chenrui333 deleted the uv-bzip2 branch April 24, 2024 21:16
@github-actions github-actions bot added the outdated PR was locked due to age label May 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-bottles Merge without publishing bottles outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants