Skip to content

qt@5: update build patch#170903

Merged
BrewTestBot merged 1 commit intomasterfrom
qt@5-update-patch-url
May 7, 2024
Merged

qt@5: update build patch#170903
BrewTestBot merged 1 commit intomasterfrom
qt@5-update-patch-url

Conversation

@chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

upstream patch got moved, thus vendoring it out.

found in #170649

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels May 6, 2024
@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue legacy Relates to a versioned @ formula CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue labels May 6, 2024
@chenrui333 chenrui333 removed CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels May 6, 2024
@fxcoudert fxcoudert added the long build Set a long timeout for formula testing label May 6, 2024
@fxcoudert
Copy link
Member

Definitely needs long build, even without recursive deps

@chenrui333 chenrui333 added the CI-linux-self-hosted Build on Linux self-hosted runner label May 6, 2024
@SMillerDev SMillerDev added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 6, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 7, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label May 7, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit 98c1b49 May 7, 2024
@BrewTestBot BrewTestBot deleted the qt@5-update-patch-url branch May 7, 2024 05:11
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula long build Set a long timeout for formula testing nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants