Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Aug 13, 2024

The latest 2.7.0 release is under a non-free license as defined by DFSG. However, the last commit in HEAD does switch the license to MIT but there has been no new release including this change.

See HewlettPackard/netperf@3bc455b


Alternatively, we could distribute the latest commit. This is what Debian and Fedora do.

There is a large number of repositories that do ship netperf in case that is important in our decision - https://repology.org/project/netperf/versions

On the other hand, the install count within Homebrew isn't that high:

install: 23 (30 days), 78 (90 days), 414 (365 days)
install-on-request: 23 (30 days), 78 (90 days), 414 (365 days)
build-error: 0 (30 days)

The latest 2.7.0 release is under a non-free license as defined by DFSG.
However, the last commit in HEAD does switch the license to MIT but
there has been no new release including this change.

See HewlettPackard/netperf@3bc455b
@cho-m cho-m added maintainer feedback Additional maintainers' opinions may be needed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. license License PRs automerge-skip `brew pr-automerge` will skip this pull request labels Aug 13, 2024
@github-actions github-actions bot added marked for removal/rejection PR is probably going to be closed or formula deleted and removed automerge-skip `brew pr-automerge` will skip this pull request labels Aug 13, 2024
@cho-m cho-m added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 13, 2024
@sgerrand
Copy link
Contributor

Alternatively, we could distribute the latest commit. This is what Debian and Fedora do.

This gets my non-maintainer vote as an end user.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to patch in the latest commit with the license change? Otherwise I think we should remove this.

@cho-m
Copy link
Member Author

cho-m commented Aug 19, 2024

Are we able to patch in the latest commit with the license change? Otherwise I think we should remove this.

Pretty large commit due to modifying every file with new license. Given there are commits between this and last release (2015-07-20), I doubt it cleanly applies.

@Bo98
Copy link
Member

Bo98 commented Aug 19, 2024

Are we able to patch in the latest commit with the license change? Otherwise I think we should remove this.

Pretty large commit due to modifying every file with new license. Given there are commits between this and last release (2015-07-20), I doubt it cleanly applies.

A license is only really valid if we cherry picked every change in between too. While upstream signed off the state at the time the license change, they did not sign off the previous release.

(https://github.com/HewlettPackard/netperf/compare/netperf-2.7.0...3bc455b23f901dae377ca0a558e1e32aa56b31c4.patch)

With that said, it seems like there's no maintainer anymore: HewlettPackard/netperf#46 (comment)

@p-linnane
Copy link
Member

A license is only really valid if we cherry picked every change in between too. While upstream signed off the state at the time the license change, they did not sign off the previous release.

(HewlettPackard/netperf@netperf-2.7.0...3bc455b23f901dae377ca0a558e1e32aa56b31c4.patch)

I hadn't checked to see the full diff. If it's that much...then we should definitely remove this.

@p-linnane p-linnane removed maintainer feedback Additional maintainers' opinions may be needed automerge-skip `brew pr-automerge` will skip this pull request labels Aug 19, 2024
@p-linnane p-linnane added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit 2736044 Aug 19, 2024
@p-linnane p-linnane deleted the netperf-remove branch August 19, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. license License PRs marked for removal/rejection PR is probably going to be closed or formula deleted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants