vineyard: fix test on Linux#191631
Merged
BrewTestBot merged 2 commits intoHomebrew:masterfrom Sep 24, 2024
Merged
Conversation
6 tasks
carlocab
reviewed
Sep 23, 2024
0dc176b to
137d716
Compare
Member
|
Also, note: since there is no Linux bottle (because the test failed when rebuilding it for |
904a6af to
ded1ff0
Compare
ded1ff0 to
58e79c1
Compare
Contributor
Author
|
Ok, this seems ready to me. I removed the compiler overrides associated with this comment “macos AppleClang doesn't support -fopenmp”. Actually, Apple clang can use -fopenmp when libomp.rb is installed, but that wasn’t necessary here because the vineyard build only enables openmp on Linux. |
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Test on Linux was broken by #181351 (cannot find -lomp since llvm updated to 19.1.0)