Skip to content

vineyard: fix test on Linux#191631

Merged
BrewTestBot merged 2 commits intoHomebrew:masterfrom
lukeshingles:fixvineyard-llvm19
Sep 24, 2024
Merged

vineyard: fix test on Linux#191631
BrewTestBot merged 2 commits intoHomebrew:masterfrom
lukeshingles:fixvineyard-llvm19

Conversation

@lukeshingles
Copy link
Contributor

@lukeshingles lukeshingles commented Sep 23, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Test on Linux was broken by #181351 (cannot find -lomp since llvm updated to 19.1.0)

@github-actions github-actions bot added no Linux bottle Formula has no Linux bottle boost Boost use is a significant feature of the PR or issue labels Sep 23, 2024
@carlocab carlocab changed the title vineyard: update formula (fix test on Linux) vineyard: fix test on Linux Sep 23, 2024
@carlocab
Copy link
Member

Also, note: since there is no Linux bottle (because the test failed when rebuilding it for llvm@18), CI will not show ❌ if there are failures on Linux. You'll need to open up the log to check if your changes worked.

@lukeshingles lukeshingles force-pushed the fixvineyard-llvm19 branch 15 times, most recently from 904a6af to ded1ff0 Compare September 24, 2024 06:02
@lukeshingles lukeshingles marked this pull request as ready for review September 24, 2024 07:28
@lukeshingles
Copy link
Contributor Author

lukeshingles commented Sep 24, 2024

Ok, this seems ready to me. I removed the compiler overrides associated with this comment “macos AppleClang doesn't support -fopenmp”. Actually, Apple clang can use -fopenmp when libomp.rb is installed, but that wasn’t necessary here because the vineyard build only enables openmp on Linux.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; great work!

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 24, 2024
@github-actions github-actions bot removed the no Linux bottle Formula has no Linux bottle label Sep 24, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 24, 2024
Merged via the queue into Homebrew:master with commit 8cfbcb9 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants