-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netcdf: remove workaround #192118
Merged
Merged
netcdf: remove workaround #192118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
approved these changes
Sep 27, 2024
I have a workaround in mind for |
It breaks some third-party builds. We should try a more tightly-scoped workaround for vtk instead. See discussion at #170959.
carlocab
force-pushed
the
netcdf-rm-workaround
branch
from
September 27, 2024 21:35
bb37cf4
to
7169482
Compare
carlocab
added
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
and removed
long dependent tests
Set a long timeout for dependent testing
labels
Sep 28, 2024
github-actions
bot
added
the
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
label
Sep 28, 2024
carlocab
added a commit
that referenced
this pull request
Sep 28, 2024
carlocab
added a commit
that referenced
this pull request
Sep 28, 2024
carlocab
added a commit
that referenced
this pull request
Sep 28, 2024
carlocab
added a commit
that referenced
this pull request
Sep 28, 2024
carlocab
added a commit
that referenced
this pull request
Sep 28, 2024
carlocab
added a commit
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?It breaks some third-party builds. We should try a more tightly-scoped
workaround for vtk instead.
See discussion at #170959.