Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcdf: remove workaround #192118

Merged
merged 2 commits into from
Sep 28, 2024
Merged

netcdf: remove workaround #192118

merged 2 commits into from
Sep 28, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

It breaks some third-party builds. We should try a more tightly-scoped
workaround for vtk instead.

See discussion at #170959.

@carlocab carlocab mentioned this pull request Sep 27, 2024
6 tasks
@carlocab
Copy link
Member Author

I have a workaround in mind for vtk that might allow us to still build it.

carlocab added a commit that referenced this pull request Sep 27, 2024
@carlocab carlocab added the long dependent tests Set a long timeout for dependent testing label Sep 27, 2024
It breaks some third-party builds. We should try a more tightly-scoped
workaround for vtk instead.

See discussion at #170959.
@carlocab carlocab added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed long dependent tests Set a long timeout for dependent testing labels Sep 28, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 28, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 28, 2024
Merged via the queue into master with commit 9356e3f Sep 28, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the netcdf-rm-workaround branch September 28, 2024 18:17
carlocab added a commit that referenced this pull request Sep 28, 2024
carlocab added a commit that referenced this pull request Sep 28, 2024
carlocab added a commit that referenced this pull request Sep 28, 2024
carlocab added a commit that referenced this pull request Sep 28, 2024
carlocab added a commit that referenced this pull request Sep 28, 2024
carlocab added a commit that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants