Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgal 6.0 #192120

Merged
merged 2 commits into from
Sep 29, 2024
Merged

cgal 6.0 #192120

merged 2 commits into from
Sep 29, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` boost Boost use is a significant feature of the PR or issue labels Sep 27, 2024
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 27, 2024
@carlocab carlocab force-pushed the bump-cgal-6.0 branch 2 times, most recently from 7d5b6e9 to 678bfbf Compare September 28, 2024 18:10
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Sep 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Bottle publish failed.

@carlocab carlocab force-pushed the bump-cgal-6.0 branch 2 times, most recently from 7971723 to c0efaba Compare September 28, 2024 19:38
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Bottle publish failed.

@carlocab
Copy link
Member

carlocab commented Sep 28, 2024 •
edited
Loading 

Error: cgal should have an `:all` bottle but one cannot be created

Huh, thought I fixed that. Let's see... The Linux bottle still has a different checksum for some reason.

@carlocab carlocab force-pushed the bump-cgal-6.0 branch 6 times, most recently from 3a248d3 to e264b5c Compare September 29, 2024 01:45
@BrewTestBot @carlocab
cgal 6.0
5985751 
- remove FindOpenMesh.cmake
- test with Qt6
- remove README.md and readme.md, since this causes different bottles to
  be built between macOS and Linux

Co-authored-by: Carlo Cabrera <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
cho-m
cho-m approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@cho-m cho-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a case-insensitive filesystem difference

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 29, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 29, 2024
Merged via the queue into master with commit bda5558 Sep 29, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-cgal-6.0 branch September 29, 2024 04:14
@carlocab
Copy link
Member

Looks like a case-insensitive filesystem difference

Partly, yes, but there's also something else at play that I didn't work out:

The README.md file that gets installed only on Linux somehow gets generated at some point during the build. I thought that it didn't get generated on macOS because of the readme.md file in buildpath, but doing rm readme.md at the start of install didn't change anything.

@cho-m
Copy link
Member

cho-m commented Sep 29, 2024 •
edited
Loading

I think it should just be README.md and readme.md are included in the same directory of source distribution. When unpacking, the ordering will then impact which file gets overwritten on a case-insensitive filesystem like macOS.

EDIT: Anyway, neither file is that useful to end-user so removal is fine.

@carlocab
Copy link
Member

Huh, I could swear I checked the source tarball for README.md while testing it out in a Linux container. Must've missed it.

lrineau
lrineau reviewed Oct 1, 2024
View reviewed changes
Formula/c/cgal.rb
Comment on lines +43 to +45

# These cause different bottles to be built between macOS and Linux for some reason.
%w[README.md readme.md].each { |file| (buildpath/file).unlink if (buildpath/file).exist? }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for that. Our test process missed that a few files were added to CGAL-6.0 root directory, and in particular a file readme.md. See CGAL/cgal@0444375.

It will be fixed in CGAL-6.0.1, that I plan to publish soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem; thanks for the update!

@lrineau lrineau mentioned this pull request Oct 1, 2024
Open
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@lrineau lrineau lrineau left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@cho-m cho-m cho-m approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
boost Boost use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BrewTestBot @carlocab @cho-m @chenrui333 @lrineau