Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
AuthServer
Minor updates to test code from changes in GMS and Vitess to refactor the
AuthServer
interface.Depends on: Refactor:
AuthServer
dolthub/go-mysql-server#2757mysql.NewSalt()
In preparation for refactoring the auth server interface in Vitess/GMS, this change makes LateBindQueryist call
mysql.NewSalt()
directly, instead of relying on theNewSalt()
method on theMySQLDb
instance (which internally callsmysql.NewSalt()
).go-mysql-server
fixes: Support
SET SQL_MODE='NO_AUTO_VALUE_ON_ZERO'
dolthub/dolt#8584This potentially fixes:
There's a longer comment in the code itself, but the summary is that this is a character set conversion issue. Perhaps it's repertoires or something else, but hopefully this moves us closer to the logically correct behavior.
AuthServer
This change refactors the
AuthServer
implementation in GMS to the newAuthServer
/AuthMethod
structure from RefactorAuthServer
to support multiple authentication methods dolthub/vitess#379This is preliminary work to set us up to add support for
caching_sha2_password
authentication.Related to: Support
caching_sha2_password
authentication method dolthub/dolt#8496Depends on: Refactor
AuthServer
to support multiple authentication methods dolthub/vitess#379vitess
set names binary
syntax (no quotes)syntax for:
set names binary
fails.set names 'binary'
succeeds. Seems unquoted collations in MySQL are supposed to work withset names
dolthub/dolt#8574Closed Issues
SET SQL_MODE='NO_AUTO_VALUE_ON_ZERO'
SELECT DISTINCT
query