percona-server: allow building without -march=armv8.1-a+crypto#220339
Merged
BrewTestBot merged 2 commits intomasterfrom Apr 17, 2025
Merged
percona-server: allow building without -march=armv8.1-a+crypto#220339BrewTestBot merged 2 commits intomasterfrom
-march=armv8.1-a+crypto#220339BrewTestBot merged 2 commits intomasterfrom
Conversation
cho-m
added
CI-no-bottles
github-actions
Bot
added
the
icu4c
65 tasks
The `ALLOW_NO_*` arguments just control whether to make CMake error message into a non-blocking warning so can be applied everywhere. Also backport fix for CMake 4.0 in submodule
cho-m
force-pushed
the
percona-server-arm-linux
branch
from
3d6be74 to
89bc7bb
Compare
branchv
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ALLOW_NO_*arguments just control whether to make CMake error message into a non-blocking warning so can be applied everywhere.RocksDB does support runtime detection but the way Percona Server builds is by using
-march=on all files - https://github.com/percona/percona-server/blob/Percona-Server-8.4.4-4/cmake/compiler_features.cmake#L266This seems less safe than the way MariaDB handles it by only changing
-march=or using-msse4.2on the specific file - https://github.com/MariaDB/server/blob/main/storage/rocksdb/build_rocksdb.cmake#L477-L478